Re: JDK9 Review Request for 8138881: Bug in OSInfo.java

2015-10-18 Thread Rajeev Chamyal
Hello Sergey, Thanks for the review. The test was working before the fix as well. The current implementation of OSInfo.getWindowsVersion() adds the missing values also to windowsVersionMap. So test always passes. Regards, Rajeev Chamyal -Original Message- From: Sergey Bylokhov Sent: 1

Re: [9-client] Review request for bug :7133530 javax/swing/JRadioButton/4314194/bug4314194.java fails on MacOS

2015-10-18 Thread Sergey Bylokhov
I just have run the test on my local system and see that it works as expected on the latest jdk9. It seems this bug in jdk was fixed already(the similar issue on windows JDK-8075785). I suggest not to close the bug as duplicate but update the test and move it to the public.(probably it will be

Re: JDK9 Review Request for 8138881: Bug in OSInfo.java

2015-10-18 Thread Sergey Bylokhov
After some additional review I am not sure that this test is useful, are you sure that the test fails before the fix? On 15.10.15 11:26, Rajeev Chamyal wrote: Hello Sergey, Thanks for the review. I have updated the webrev with review comments. WebRev : http://cr.openjdk.java.net/~rchamyal/813