Re: Review request for JDK-8079253 Test javax/swing/SwingUtilities/TestBadBreak/TestBadBreak.java fails

On 11/6/2015 1:21 PM, Rajeev Chamyal wrote: Hello Alexander, Thanks for the review. We need to set the opaque property on the label as well. I see. The idea is that we do not fix tests itself so they just work. The tests are necessary to find as much issues as possible. If this

Review request for JDK-8079253 Test javax/swing/SwingUtilities/TestBadBreak/TestBadBreak.java fails

Hello All, Please review the following fix for Jdk9: Bug: https://bugs.openjdk.java.net/browse/JDK-8079253 Webrev: http://cr.openjdk.java.net/~rchamyal/8079253/webrev.00/ Issue: The test case shortens two text labels and writes the resulting same strings to buffered images. On Ubuntu

Re: [9] Review Request for 8140527: JInternalFrame has incorrect title button width

On 10/28/2015 12:54 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8140527 webrev: http://cr.openjdk.java.net/~ssadetsky/8140527/webrev.00/ Title buttons under Widows Classic LnF got their sizes from the XP desktop theme in which

Re: Review request for JDK-8079253 Test javax/swing/SwingUtilities/TestBadBreak/TestBadBreak.java fails

On 11/6/2015 12:38 PM, Rajeev Chamyal wrote: Hello All, Please review the following fix for Jdk9: Bug:https://bugs.openjdk.java.net/browse/JDK-8079253 Webrev:http://cr.openjdk.java.net/~rchamyal/8079253/webrev.00/ Issue: The

Re: Review request for JDK-8079253 Test javax/swing/SwingUtilities/TestBadBreak/TestBadBreak.java fails

Hello Alexander, Thanks for the review. We need to set the opaque property on the label as well. Regards, Rajeev Chamyal -Original Message- From: Alexander Scherbatiy Sent: 06 November 2015 15:39 To: Rajeev Chamyal Cc: Sergey Bylokhov; swing-dev@openjdk.java.net Subject: Re: Review

Re: Review request for JDK-8079253 Test javax/swing/SwingUtilities/TestBadBreak/TestBadBreak.java fails

On 06.11.15 13:27, Alexander Scherbatiy wrote: The issue the the opaque property can be added as a comment to the JDK-8073710 bug so it will be updated with the JDK-8073710 fix. I guess that the opaque property is unrelated to the size and is unrelated to the JDK-8073710, we can fix it

Re: Review request for JDK-6288609 JInternalFrame.setDefaultCloseOperation() interferes with "close" behavior

On 10/29/2015 10:41 AM, Rajeev Chamyal wrote: Hello All, Please review the following fix for Jdk9: *Bug*:https://bugs.openjdk.java.net/browse/JDK-6288609 *Webrev*:http://cr.openjdk.java.net/~rchamyal/6288609/webrev.00/