Re: Review request for JDK-8075084 JOptionPane.showMessageDialog causes JScrollBar to move

2015-12-25 Thread Sergey Bylokhov
Probably this bug can be fixed in a different way. Is it possible to check the state of the scroll bar in the timer? And if in some iteration the button became unpressed then stops itself(timer). On 23/12/15 12:29, Rajeev Chamyal wrote: Hello Alexandr, The modal dialog can be application moda

Re: Review request for JDK-8145060 Minimizing a JInternal frame not shifting focus to frame below it

2015-12-25 Thread Sergey Bylokhov
Hi, Rajeev. I guess "d.setComponentOrderCheckingEnabled(false);" should be moved also for consistency. On 14/12/15 08:32, Rajeev Chamyal wrote: Hello All, Please review the following fix for Jdk9: Bug: https://bugs.openjdk.java.net/browse/JDK-8145060 Webrev:http://cr.openjdk.java.net/~rcham

Re: Review request for JDK-4769772 JInternalFrame.setIcon(true) before JDesktopPane.add(JIF) causes wrong state

2015-12-25 Thread Alexey Ivanov
Hi Rajeev, Thank you for updating the code. I have a couple more questions though. 1. SynthDesktopPaneUI What is the purpose of this line? d.setBounds(r.x, r.y, r.width, r.height); Since d is a JDesktopPane which contains the frame, you change the location and size of the desktop pane to