Re: Review request for JDK-8145060 Minimizing a JInternal frame not shifting focus to frame below it

2015-12-27 Thread Rajeev Chamyal
Hello Sergey, Thanks for the review. I have updated the code. http://cr.openjdk.java.net/~rchamyal/8145060/webrev.01/ Regards, Rajeev Chamyal -Original Message- From: Sergey Bylokhov Sent: 25 December 2015 21:23 To: Rajeev Chamyal; Alexander Scherbatiy; Prasanta Sadhukhan; swing-dev@op

Re: Review request for JDK-4769772 JInternalFrame.setIcon(true) before JDesktopPane.add(JIF) causes wrong state

2015-12-27 Thread Rajeev Chamyal
Hello Alexey, Thanks for the review. I have updated the code as suggested. http://cr.openjdk.java.net/~rchamyal/4769772/webrev.02/ Please see response to questions inline. Regards, Rajeev Chamyal -Original Message- From: Alexey Ivanov Sent: 25 December 2015 18:14 To: Rajeev Chamyal; swi

Re: Review request for 8016665: [macosx] JComponent behaviour doesn't comply API documentation (setComponentOrientation method), Aqua LAF

2015-12-27 Thread Avik Niyogi
Hi Alexandr, Automated test may fail based on folder contents on individual systems irrespective of the fix directly not depending on the same. Also, to confirm this fix, it will need visual confirmation and hence, no automated test was provided. With Regards, Avik Niyogi > On 23-Dec-2015, at

Re: Review request for JDK-8075084 JOptionPane.showMessageDialog causes JScrollBar to move

2015-12-27 Thread Rajeev Chamyal
Hello Sergey, The first webrev version is implemented on similar lines as you suggested but it had issues as pointed my Alexandr in his review below. If the mouse pointer after clicking on modal dialog close lies outside the parent window then parent window is not getting any mouse events and