Re: [9] Review Request for 8081722: Provide public API for file hierarchy provided by sun.awt.shell.ShellFolder

On 12/3/2015 2:02 PM, Alexander Scherbatiy wrote: It is better to have concrete methods like Image getFileChooserIcon(String iconName) rather to have one unified method for all cases. Please see the updated webrev: http://cr.openjdk.java.net/~ssadetsky/8081722/webrev.03/ get(String) is

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

Hi All, A gentle reminder. Please review my code changes as mentioned in the webrev below as available in the link in the mail trail. With Regards, Avik Niyogi > On 18-Jan-2016, at 11:34 am, Avik Niyogi wrote: > > Hi All, Please find the changes as provided with

Re: [9] Review Request for 8081722: Provide public API for file hierarchy provided by sun.awt.shell.ShellFolder

Hi Semyon, > http://cr.openjdk.java.net/~ssadetsky/8081722/webrev.03/ > get(String) is replaced with getChooserComboBoxFiles(). Other get() keys are > not in use by NetBeans. Please move the new methods after the constructor of the FileSystemView class. The description of the return value

Re: Review request for JDK-8139213 : Mac OS X Aqua Look and Feel: JOptionPane can truncate the first button.

Hello All, Gentle reminder for review. Regards, Rajeev Chamyal -Original Message- From: Rajeev Chamyal Sent: 13 January 2016 16:37 To: Sergey Bylokhov; Alexander Scherbatiy; Prasanta Sadhukhan; swing-dev@openjdk.java.net Subject: Review request for JDK-8139213 : Mac OS X Aqua Look and

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

Hello Avik, All exception caught during test should mark the test as failed. For example not able to set any LAF should also be considered as test failure. Regards, Rajeev Chamyal From: Avik Niyogi Sent: 20 January 2016 10:20 To: Rajeev Chamyal Cc: Alexander Scherbatiy; Sergey

Re: Review request for JDK-8139213 : Mac OS X Aqua Look and Feel: JOptionPane can truncate the first button.

Hello Alexandr, Thanks for the review. Yes, we can call minimumLayoutSize(Container) of parent class but in this case also again we need to check if any of the child components are setting preferred size and compare it with the default values. And after this we need to find a delta that

Re: Review Request of 8146321: [macosx] JInternalFrame frame icon in wrong position on Mac L if icon is not ImageIcon

Hi All, A gentle reminder, please review my code changes as in the webrev below in the mail trail. With Regards, Avik Niyogi > On 18-Jan-2016, at 3:01 pm, Avik Niyogi wrote: > > Hi Sergey, > > Please review the webrev taking inputs as per the discussion before: >

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

Hi All, Please review the code changes made as with inputs for the webrev: http://cr.openjdk.java.net/~aniyogi/8015748/webrev.07/ With Regards, Avik Niyogi > On 20-Jan-2016, at 10:40 am, Rajeev Chamyal wrote:

Re: [9] Review Request for 8081722: Provide public API for file hierarchy provided by sun.awt.shell.ShellFolder

Hi Andrej, The webrev is updated: http://cr.openjdk.java.net/~ssadetsky/8081722/webrev.04/ --Semyon On 1/19/2016 2:28 PM, Andrej Golovnin wrote: Hi Semyon, http://cr.openjdk.java.net/~ssadetsky/8081722/webrev.03/ get(String) is replaced with getChooserComboBoxFiles(). Other get() keys are

Re: Review Request for Bug 8146320 JTextField ignores setPreferredSize when having columns

On 18/01/16 14:46, Prem Balakrishnan wrote: Hi, Please review fix for JDK9, *Bug:*https://bugs.openjdk.java.net/browse/JDK-8146320 *Webrev:*http://cr.openjdk.java.net/~rchamyal/prem/8146320/webrev.00/ *Issue:* JTextField

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

The fix looks good to me. Thanks, Alexandr. On 19/01/16 15:27, Avik Niyogi wrote: Hi All, A gentle reminder. Please review my code changes as mentioned in the webrev below as available in the link in the mail trail. With Regards, Avik Niyogi On 18-Jan-2016, at 11:34 am, Avik Niyogi

Re: Review request for JDK-8146276 : Right aligned ToolBar component does not appear

On 12/01/16 08:21, Rajeev Chamyal wrote: Hello All, Please review the following fix for Jdk9: Bug : https://bugs.openjdk.java.net/browse/JDK-8146276 Webrev: http://cr.openjdk.java.net/~rchamyal/8146276/webrev.00/ Issue : Right aligned ToolBar component does not appear Cause: While calculating

Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception

The fix looks good to me. Thanks, Alexandr. On 11/01/16 13:57, Rajeev Chamyal wrote: Hello Sergey, Could you please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8145896/webrev.01/ Regards, Rajeev Chamyal -Original Message- From: Rajeev Chamyal Sent: 02 January

Re: Review request for JDK-8139213 : Mac OS X Aqua Look and Feel: JOptionPane can truncate the first button.

On 19/01/16 15:48, Rajeev Chamyal wrote: Hello All, Gentle reminder for review. Regards, Rajeev Chamyal -Original Message- From: Rajeev Chamyal Sent: 13 January 2016 16:37 To: Sergey Bylokhov; Alexander Scherbatiy; Prasanta Sadhukhan; swing-dev@openjdk.java.net Subject: Review