Re: [9] Review Request for 8081722: Provide public API for file hierarchy provided by sun.awt.shell.ShellFolder

2016-01-21 Thread Semyon Sadetsky
On 1/21/2016 6:25 PM, Sergey Bylokhov wrote: On 21/01/16 09:16, Semyon Sadetsky wrote: There are still inconsistency. The isFileSystem(), isParent(), getSystemIcon, getSystemDisplayName() etc do not throw an exception in case of null, but return some default value(null,true,false). Same for F

Re: [9] Review Request for 8081722: Provide public API for file hierarchy provided by sun.awt.shell.ShellFolder

2016-01-21 Thread Sergey Bylokhov
On 21/01/16 09:16, Semyon Sadetsky wrote: There are still inconsistency. The isFileSystem(), isParent(), getSystemIcon, getSystemDisplayName() etc do not throw an exception in case of null, but return some default value(null,true,false). Same for FileNotFoundException() most of the methods just

Re: Review Request for Bug 8146320 JTextField ignores setPreferredSize when having columns

2016-01-21 Thread Andrej Golovnin
Hi Perm, I'm sorry, my mistake. To see the difference you must run the example with JDK 8, e.g. without your patch. The example contains two fields "jdk8" and "jdk9". The "jdk9" field simulates the behaviour of JTextField with your patch. Both fields "jdk8" and "jdk9" should have the same size on

Re: Review Request for Bug 8146320 JTextField ignores setPreferredSize when having columns

2016-01-21 Thread Prem Balakrishnan
Hi Andrej, I executed the below test code. Didn’t find any inconsistent behavior before and after the fix. Can you give little brief description on the issues, which this fix may give rise to. Regards, Prem I -Original Message- From: Andrej Golovnin [mailto:andrej.golov...@gmail.com]

Re: Review request for JDK-8146276 : Right aligned ToolBar component does not appear

2016-01-21 Thread prasanta sadhukhan
FIx looks good to me too. Regards Prasanta On 1/20/2016 5:06 PM, Alexander Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 1/20/2016 9:52 AM, Rajeev Chamyal wrote: Hello Alexandr, Thanks for the review. This issue is seen only if we have glue added to any SynthToolBa

Re: Review Request for Bug 8146320 JTextField ignores setPreferredSize when having columns

2016-01-21 Thread Andrej Golovnin
Hi all, as a long time Swing developer I want to vote against this change. This change may break the layout of existing applications and make them unusable. This code exists for very long time. And it should stay as is. The only change that you should make is to document the current behaviour. Pl

Re: Review request for JDK-8139213 : Mac OS X Aqua Look and Feel: JOptionPane can truncate the first button.

2016-01-21 Thread prasanta sadhukhan
Fix looks good to me. Regards Prasanta On 1/20/2016 6:18 PM, Alexander Scherbatiy wrote: On 1/20/2016 3:45 PM, Rajeev Chamyal wrote: Hello Alexandr, Thanks for the review. I have updated the webrev as suggested. http://cr.openjdk.java.net/~rchamyal/8139213/webrev.01/ The fix looks good to