Re: Review Request of 8146321: [macosx] JInternalFrame frame icon in wrong position on Mac L&F if icon is not ImageIcon

2016-02-02 Thread Alexandr Scherbatiy
On 2/2/2016 3:41 AM, Avik Niyogi wrote: Hi Alexander, On 02-Feb-2016, at 3:44 pm, Alexandr Scherbatiy > wrote: On 2/2/2016 1:50 AM, Avik Niyogi wrote: Hi All, Please review the code changes made as per the inputs provided: cr.openjdk.java.net/~aniyogi/8

Re: Review Request of 8146321: [macosx] JInternalFrame frame icon in wrong position on Mac L&F if icon is not ImageIcon

2016-02-02 Thread Avik Niyogi
Hi Alexander, > On 02-Feb-2016, at 3:44 pm, Alexandr Scherbatiy > wrote: > > On 2/2/2016 1:50 AM, Avik Niyogi wrote: >> Hi All, >> Please review the code changes made as per the inputs provided: >> cr.openjdk.java.net/~aniyogi/8146321/webrev.03 >>

Re: Review Request for 8062846 : Transparent JDialog will lose transparency upon iconify/deiconify sequence.

2016-02-02 Thread Prem Balakrishnan
Hi Ambarish, Updated test . Webrev: http://cr.openjdk.java.net/~arapte/prem/8062946/webrev.01/ Regards, Prem From: Ambarish Rapte Sent: Tuesday, February 02, 2016 2:47 PM To: Alexander Scherbatiy; Prem Balakrishnan; Semyon Sadetsky; Sergey Bylokhov; Rajeev Chamyal; swing-dev@openj

Re: Review Request of 8146321: [macosx] JInternalFrame frame icon in wrong position on Mac L&F if icon is not ImageIcon

2016-02-02 Thread Alexandr Scherbatiy
On 2/2/2016 1:50 AM, Avik Niyogi wrote: Hi All, Please review the code changes made as per the inputs provided: cr.openjdk.java.net/~aniyogi/8146321/webrev.03 - Will it work with custom implementation of the Icon interface which just

Re: Review Request of 8146321: [macosx] JInternalFrame frame icon in wrong position on Mac L&F if icon is not ImageIcon

2016-02-02 Thread Avik Niyogi
Hi All, Please review the code changes made as per the inputs provided: cr.openjdk.java.net/~aniyogi/8146321/webrev.03 With Regards, Avik Niyogi > On 02-Feb-2016, at 3:02 pm, Alexandr Scherbatiy > wrote: > > On 2/1/2016 11:25 PM, Avik Niy

Re: Review Request of 8146321: [macosx] JInternalFrame frame icon in wrong position on Mac L&F if icon is not ImageIcon

2016-02-02 Thread Alexandr Scherbatiy
On 2/1/2016 11:25 PM, Avik Niyogi wrote: Hi All, Please review the code changes made as per inputs provided: cr.openjdk.java.net/~aniyogi/8146321/webrev.02 - is it possible to skip the ImageIcon parsing and handle it as others icons

Re: Review Request for 8062846 : Transparent JDialog will lose transparency upon iconify/deiconify sequence.

2016-02-02 Thread Ambarish Rapte
Hi Prem, The test passes without including the fix. The test should fail without fix, and should pass with fix. Thanks, Ambarish From: Alexandr Scherbatiy Sent: Monday, February 01, 2016 5:15 PM To: Prem Balakrishnan; Semyon Sadetsky; Sergey Bylokhov; Amb