Re: Review Request for 7126823 : JInternalFrame.getNormalBounds() returns bad value after iconify/deiconify

2016-02-18 Thread Prem Balakrishnan
Hi Semyon, Thanks for the review, Test Updated as per review points Webrev: http://cr.openjdk.java.net/~arapte/prem/7126823/webrev.03/ Regards, Prem From: Semyon Sadetsky Sent: Thursday, February 18, 2016 2:33 PM To: Prem Balakrishnan; Rajeev Chamyal; Alexander Scherbatiy Cc

Re: [9] Review fix for JDK-8020039 : SynthTableHeaderUI refers to possibly null parameter in cell renderer

2016-02-18 Thread Miguel Munoz
It would seem to me that if the table is null, you have a bug in another class. Is there a valid reason for the table to be null? I would guess not. In my experience, many null checks are either unnecessary or only serve to hide bugs. Steve Maguire writes about this in his book Writing Solid Cod

Re: Review Request for 7126823 : JInternalFrame.getNormalBounds() returns bad value after iconify/deiconify

2016-02-18 Thread Semyon Sadetsky
Hi Prem, In the test getLocationOnScreen(), getBounds() and getNormalBounds() should be called on EDT for Swing components. --Semyon On 2/15/2016 11:51 AM, Prem Balakrishnan wrote: Hi Rajeev, Test updated as per your comments. *Webrev:*http://cr.openjdk.java.net/~arapte/prem/7126823/webr