Re: Review Request of 8151282: [TEST_BUG] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java fails with GTK LnF

2016-03-22 Thread Sergey Bylokhov
Looks fine. On 22.03.16 10:38, Avik Niyogi wrote: Hi All, Please find webrev with new code fix: http://cr.openjdk.java.net/~aniyogi/8151282/webrev.02/ With Regards, Avik Niyogi On 21-Mar-2016, at 8:07 pm, Sergey Bylokhov > wrote:

Re: [9] Review request for JDK-8150225 api/javax_swing/text/AbstractWriter/index_indent failed

2016-03-22 Thread Sergey Bylokhov
Looks fine to me. But I am not an expert here. And I wonder why the tag is so specific, can we get the similar issue if some other tags will be used instead? On 22.03.16 11:35, Rajeev Chamyal wrote: Hello All, Gentle reminder. Please review the fix. Bug :

Re: [9] Review Request for 8078514: Nightly: api/javax_swing/DefaultRowSorter/index_ModelStructChanged failure

2016-03-22 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 12/8/2015 11:04 PM, Semyon Sadetsky wrote: On 12/8/2015 10:56 PM, Sergey Bylokhov wrote: On 02/11/15 16:51, Semyon Sadetsky wrote: On 5/26/2015 1:38 PM, Alexander Scherbatiy wrote: On 5/21/2015 5:34 PM, Semyon Sadetsky wrote: Hello, I have

Re: Review request for JDK-8075084 JOptionPane.showMessageDialog causes JScrollBar to move

2016-03-22 Thread Rajeev Chamyal
Hello All, Please review the re-worked fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8075084 Webrev : http://cr.openjdk.java.net/~rchamyal/8075084/webrev.03/ In the updated fix a global awt event listener has been added to BasicScrollBarUI to take actions on mouse events. The awt event

Re: Review Request for 6439354 : Win L: TitledBorder colors are not from desktop

2016-03-22 Thread Prem Balakrishnan
Hi Sergey, Updated test as per the review comments. Webrev: http://cr.openjdk.java.net/~arapte/prem/6439354/webrev.01/ Regards, Prem -Original Message- From: Sergey Bylokhov Sent: Monday, March 21, 2016 7:31 PM To: Prem Balakrishnan; Semyon Sadetsky; Rajeev Chamyal; Alexander

Re: [9] Review request for JDK-8150225 api/javax_swing/text/AbstractWriter/index_indent failed

2016-03-22 Thread Rajeev Chamyal
Hello All, Gentle reminder. Please review the fix. Bug : https://bugs.openjdk.java.net/browse/JDK-8150225 Webrev: http://cr.openjdk.java.net/~rchamyal/8150225/webrev.00/ Regards, Rajeev Chamyal -Original Message- From: Rajeev Chamyal Sent: 09 March 2016 15:58 To: Sergey Bylokhov;

Re: Review Request of 8151282: [TEST_BUG] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java fails with GTK LnF

2016-03-22 Thread Avik Niyogi
Hi All, Please find webrev with new code fix: http://cr.openjdk.java.net/~aniyogi/8151282/webrev.02/ With Regards, Avik Niyogi > On 21-Mar-2016, at 8:07 pm, Sergey Bylokhov > wrote: > > Hi, Avik. > How this

RFR JDK-8143021: [TEST_BUG] Test javax/swing/JColorChooser/Test6541987.java fails for Ubuntu 15.10

2016-03-22 Thread Ahmad Ahmad
Hello, Please review fix for JDK9 test bug. Bug: https://bugs.openjdk.java.net/browse/JDK-8143021 Webrev: http://cr.openjdk.java.net/~srastogi/shaik/webrev.01/ Issue: java.lang.Error: found visible window: frame0 at Test6541987.main(Test6541987.java:64) Cause: Test is failing