Re: [9] Review request for 8151015: JTextArea.insert() does not behave as expected with invalid position

2016-03-29 Thread Phil Race
There is actually a test for the previous bug - called bug4496801.java, but it is in closed. I suggest it be opened as part of this fix. Also run any (all) related Swing regression tests that might cover this area. I am a little nervous that since the original fix was 13 years ago that some

Re: [9] Review request for 8146301: Enter key does not work in a deserialized JFileChooser

2016-03-29 Thread Phil Race
The fix looks fine to me and I agree the OS X problem is a distinct one. -phil. On 03/21/2016 11:05 AM, Semyon Sadetsky wrote: On 3/21/2016 8:09 PM, Sergey Bylokhov wrote: On 21.03.16 19:46, Semyon Sadetsky wrote: yes. This a generic code issue. It is failed on OSX even after the fix, pleas

Re: [9] Review request for 8149631: rgb(...) CSS color values are not parsed properly

2016-03-29 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 3/29/2016 8:29 AM, Semyon Sadetsky wrote: On 3/29/2016 6:16 PM, Alexander Scherbatiy wrote: Should white spaces be removed within parentheses? I think it is better to preserve the format user specified. Spaces are a valid symbols in CSS, the

Re: [9] Review request for 8149631: rgb(...) CSS color values are not parsed properly

2016-03-29 Thread Semyon Sadetsky
On 3/29/2016 6:16 PM, Alexander Scherbatiy wrote: Should white spaces be removed within parentheses? I think it is better to preserve the format user specified. Spaces are a valid symbols in CSS, they improve readability. --Semyon Thanks, Alexandr. On 14/03/16 19:13, Semyon Sadetsky wrote:

Re: [9] Review request for 8149631: rgb(...) CSS color values are not parsed properly

2016-03-29 Thread Alexander Scherbatiy
Should white spaces be removed within parentheses? Thanks, Alexandr. On 14/03/16 19:13, Semyon Sadetsky wrote: Thanks, Sergey. The webrev is corrected. On 3/14/2016 4:22 PM, Sergey Bylokhov wrote: Something strange occurs in the webrev for the testcase, there is no diff. On 14.03.16 14:29,

Re: CFV: New Swing Group Member: Semyon Sadetsky

2016-03-29 Thread Alexander Potochkin
Vote: yes On 3/21/2016 09:01, Alexander Scherbatiy wrote: I hereby nominate Semyon Sadetsky (OpenJDK user name: ssadetsky) to Membership in the Swing Group. Semyon is active member of Swing group and contributed a lot of fixes which include Swing TimerQueue race condition improvement, Undo

Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

2016-03-29 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 24/03/16 13:31, Rajeev Chamyal wrote: Looks good to me. Regards, Rajeev Chamyal *From:*Avik Niyogi *Sent:* 24 March 2016 12:54 *To:* Rajeev Chamyal; Alexander Scherbatiy; Sergey Bylokhov; swing-dev@openjdk.java.net *Subject:* Re: Review Re

Re: [9] JDK-8049069 : JButton incorrect behaviour on button release

2016-03-29 Thread Alexander Scherbatiy
On 28/03/16 15:43, Ajit Ghaisas wrote: Hi, In JDK-6u115, this bug is not reproducible. Fix for JDK-7088744 did not break the JButton behavior. This bug is regression due to changes done to SwingUtilities as a fix of JDK-7146377. After reading comments on JBS for J

Re: [9] Review Request for several test bugs: 8150535, 8151033, 8151037 etc.

2016-03-29 Thread Yuri Nesterenko
Hi Semyon, (see also my answer in https://bugs.openjdk.java.net/browse/JDK-8152693 ) Unfortunately, this changeset is already pushed. Generally, some of the tests is not hard to adapt for non-modules execution mode, and let's try that sometimes, however (1) some of them already run well with jdk

Re: [9] Review Request for several test bugs: 8150535, 8151033, 8151037 etc.

2016-03-29 Thread Semyon Sadetsky
Hi Yuri, Is it possible to make those tests to run on both Jigsaw and non-Jigsaw JDKs? Some tests may be unstable on Ubuntu because of https://bugs.openjdk.java.net/browse/JDK-8036915. To make stability better I propose to replace all top windows getLocation() by getLocationOnScreen() and

Re: Review request for JDK-8075084 JOptionPane.showMessageDialog causes JScrollBar to move

2016-03-29 Thread Alexander Scherbatiy
On 22/03/16 15:25, Rajeev Chamyal wrote: Hello All, Please review the re-worked fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8075084 Webrev : http://cr.openjdk.java.net/~rchamyal/8075084/webrev.03/ In the updated fix a global awt event listener has been added to BasicScrollBarUI to take

Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

2016-03-29 Thread Avik Niyogi
Hi Sergey and Alexander, Please review the code changes done. With Regards, Avik Niyogi > On 28-Mar-2016, at 1:45 pm, Avik Niyogi wrote: > > A gentle reminder, Please review the code changes as presented below. > > With Regards, > Avik Niyogi >> On 24-Mar-2016, at 3:01 pm, Rajeev Chamyal >