Re: RFR(S): 8156020: 8145547 breaks AIX and and uses RTLD_NOLOAD incorrectly

2016-05-06 Thread Phil Race
On 05/06/2016 04:33 PM, Volker Simonis wrote: Hi Phil, Thanks for looking at this problem. On Saturday, May 7, 2016, Phil Race > wrote: Hi, I've confirmed that what was pushed was v5 and it should really have been v6. I

Re: RFR(S): 8156020: 8145547 breaks AIX and and uses RTLD_NOLOAD incorrectly

2016-05-06 Thread Volker Simonis
Hi Phil, Thanks for looking at this problem. On Saturday, May 7, 2016, Phil Race wrote: > Hi, > > I've confirmed that what was pushed was v5 and it should really have been > v6. > I can't say unequivocally that it would have built on AIX but > 1) It does not use

Re: RFR(S): 8156020: 8145547 breaks AIX and and uses RTLD_NOLOAD incorrectly

2016-05-06 Thread Sergey Bylokhov
Hi. I guess the version .5 was pushed because the .6 parse "/proc". On 07.05.16 1:56, Phil Race wrote: Hi, I've confirmed that what was pushed was v5 and it should really have been v6. I can't say unequivocally that it would have built on AIX but 1) It does not use RTLD_NOLOAD anywhere 2) all

Re: RFR(S): 8156020: 8145547 breaks AIX and and uses RTLD_NOLOAD incorrectly

2016-05-06 Thread Phil Race
Hi, I've confirmed that what was pushed was v5 and it should really have been v6. I can't say unequivocally that it would have built on AIX but 1) It does not use RTLD_NOLOAD anywhere 2) all calls to dlopen include RTLD_LAZY. Here is the delta - the patch that makes v5 into v6 and although it

Re: Review Request JDK-6421058: When calls JSpinner.setEditor() the font in a JSpinner become is a bold

2016-05-06 Thread Sergey Bylokhov
Hi, Prem. The null check before instance of is not necessary: editor != null. Why the code is commented in the test "//mainFrame.dispose()"? Please review fix for JDK9, *Bug:*https://bugs.openjdk.java.net/browse/JDK-6421058 *Webrev:*http://cr.openjdk.java.net/~pkbalakr/6421058/webrev.00/

[9] Review request for 8156217 Selected text is shifted on HiDPI display

2016-05-06 Thread Alexandr Scherbatiy
Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8156217 webrev: http://cr.openjdk.java.net/~alexsch/8156217/webrev.00 This is the second part of the fix related to the fact that char width can be fractional in user space.

[9] Review request for JDK-8147521 [macosx] Internal API Usage: setPopupType used to force creation of heavyweight popup

2016-05-06 Thread Rajeev Chamyal
Hello All, Please review the below 2 webrevs. Webrev: http://cr.openjdk.java.net/~rchamyal/8147521/webrev.app.00/ http://cr.openjdk.java.net/~rchamyal/8147521/webrev.app.01/ Bug : https://bugs.openjdk.java.net/browse/JDK-8147521 Approach 1:

[9] Fix for JDK-7172750 : Nimbus ScrollBar:ScrollBarThumb[Pressed].backgroundPainter is never invoked

2016-05-06 Thread Ajit Ghaisas
Hi, Bug : https://bugs.openjdk.java.net/browse/JDK-7172750 Issue : Nimbus ScrollBar:ScrollBarThumb[Pressed].backgroundPainter is never invoked Root Cause : There is no differentiation between 'MouseOver' and Mouse 'Pressed' in scroll thumb painting. Fix : 1. Used

Re: Review Request JDK-6421058: When calls JSpinner.setEditor() the font in a JSpinner become is a bold

2016-05-06 Thread Ajit Ghaisas
Forwarding to swing group as it is a Swing Fix. From: Prem Balakrishnan Sent: Friday, May 06, 2016 2:05 PM To: Sergey Bylokhov; Semyon Sadetsky; Rajeev Chamyal; Ambarish Rapte; awt-...@openjdk.java.net Subject: Review Request JDK-6421058: When calls JSpinner.setEditor() the font in a

Re: [9] Review request for 8156128: Tests for [AWT/Swing] Conditional support for GTK 3 on Linux

2016-05-06 Thread Yuri Nesterenko
Hi Phil, yes, thank you. I've added a simpler black box test for both Linux and Solaris just verifying that neither of the flag values (well, of 2 and 3) prevents GTK LaF initialization. Here we don't try to find which version of the library is actually loaded. Please see: