keyboard (not mouse) multi-select on Mac

2016-05-11 Thread Pete Brunet
How do you do a mouseless (keyboard only) multi-select on Mac, e.g. in the List Demo of SwingSet2? On Win, to move the focus point without moving the selection, you use ctrl + arrow. Then when you are at the next list item you want to select you use ctrl + space. I tried arrow with control,

Re: [9] Review request for 8078268: javax.swing.text.html.parser.Parser parseScript incorrectly optimized

2016-05-11 Thread mikhail cherkasov
Please see update version: http://cr.openjdk.java.net/~mcherkas/8078268/webrev.02 >You don't need to create JEditorPane, you can instantiate HTMLDocument directly with new HTMLDocument(). without JEditorPane parser will be null in HTMLDocument, so it's the easiest way to init HTMLDocument right

Re: [9] Review request for 8078268: javax.swing.text.html.parser.Parser parseScript incorrectly optimized

2016-05-11 Thread Alexey Ivanov
Hi Mikhail, Can I ask you to add one space between if, while and the opening parenthesis which is in according to Java Coding Style? In your test, you use none of JFrame methods, then why do you extend JFrame? You don't need to create JEditorPane, you can instantiate HTMLDocument directly

Re: [9] Review request for 8041694: JFileChooser removes trailing spaces in the selected directory name

2016-05-11 Thread Anton Litvinov
Hi Semyon, Thank you for this information. Current version of the regression test using the shell script is tested, cross platform and does not contain any code specific to Windows platform. This shell script is a copy of many other stable regression tests existing in "jdk9/jdk/test"

Re: [9] Review request for 8041694: JFileChooser removes trailing spaces in the selected directory name

2016-05-11 Thread Semyon Sadetsky
Hi Anton, In windows you may use "\\?\" prefix with absolute path of a new folder. For example: new File("?\\C:\\tmp\\test2 ").mkdir(); --Semyon On 5/11/2016 4:47 PM, Anton Litvinov wrote: Hello Sergey, Thank you for review of this fix. No, unfortunately, on MS Windows OS, if the method

[9] Review request for 8136998: JComboBox prevents wheel mouse scrolling of JScrollPane

2016-05-11 Thread Alexey Ivanov
Hello Swing team, Could you please review the fix for jdk9: bug: https://bugs.openjdk.java.net/browse/JDK-8136998 webrev: http://cr.openjdk.java.net/~aivanov/8136998/jdk9/webrev.00/ Problem description: When JComboBox is added into a JScrollPane, scroll pane is not scrolled by mouse

[9] Review request for 8078268: javax.swing.text.html.parser.Parser parseScript incorrectly optimized

2016-05-11 Thread mikhail cherkasov
Hi all, Please review a fix for https://bugs.openjdk.java.net/browse/JDK-8078268 webrev: http://cr.openjdk.java.net/~mcherkas/8078268/webrev.01/ The problem is in the following line:

Re: [9] Review request for 8132119 Provide public API for text related methods in SwingUtilities2

2016-05-11 Thread Alexander Scherbatiy
Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8132119/webrev.12 Public methods to handle fractional text position are added to Swing. - methods which use integer position now has a pair with the same name and fractional position - methods which

Re: [9] Review request for 8041694: JFileChooser removes trailing spaces in the selected directory name

2016-05-11 Thread Sergey Bylokhov
On 11.05.16 16:47, Anton Litvinov wrote: The method "java.nio.file.Files.createDirectory(Path dir, FileAttribute... attrs)" cannot be used for this purpose also, because "java.nio.file.Path" cannot be constructed for the directory name ending with spaces and "java.io.File.toPath()" throws the

Re: [9] Review request for 8041694: JFileChooser removes trailing spaces in the selected directory name

2016-05-11 Thread Anton Litvinov
Hello Sergey, Thank you for review of this fix. No, unfortunately, on MS Windows OS, if the method "java.io.File.mkdir()" is called on "java.io.File" instance which contains trailing space characters in the directory name, the corresponding directory is created but without trailing space

Re: [9] Review request for JDK-8147521 [macosx] Internal API Usage: setPopupType used to force creation of heavyweight popup

2016-05-11 Thread Sergey Bylokhov
Code change looks fine. I think that the spec of isHeavyWeightPopup() should be updated. the "true" means that the HW popup will be forced, but the false does not mean that LW will be used(I guess in this case some default type will/can be selected). On 11.05.16 14:45, Rajeev Chamyal wrote:

[9] Review request for 8041694: JFileChooser removes trailing spaces in the selected directory name

2016-05-11 Thread Anton Litvinov
Hello, Could you please review the following fix for the bug. Bug: https://bugs.openjdk.java.net/browse/JDK-8041694 Webrev: http://cr.openjdk.java.net/~alitvinov/8041694/jdk9/webrev.00 The bug consists in the fact that the method "JFileChooser.getSelectedFile()" returns "java.io.File" object

Re: [9] Review request for JDK-8147521 [macosx] Internal API Usage: setPopupType used to force creation of heavyweight popup

2016-05-11 Thread Rajeev Chamyal
Hello Alexandr, Please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8147521/webrev.04/ Regards, Rajeev Chamyal -Original Message- From: Alexander Scherbatiy Sent: 11 May 2016 16:29 To: Rajeev Chamyal Cc: swing-dev@openjdk.java.net; Sergey Bylokhov; Alan Snyder

Re: [9] Review request for 8154431: Allow source and target based validation for the focus transfer between two JComponents.

2016-05-11 Thread Semyon Sadetsky
On 5/11/2016 12:17 AM, Phil Race wrote: On 04/22/2016 01:11 AM, Semyon Sadetsky wrote: Forget to attach the link: http://cr.openjdk.java.net/~ssadetsky/8154431/webrev.01/ --Semyon On 4/22/2016 11:08 AM, Semyon Sadetsky wrote: Please review the updated webrev: 32 * need to ensure that

Re: [9] Review request for JDK-8147521 [macosx] Internal API Usage: setPopupType used to force creation of heavyweight popup

2016-05-11 Thread Alexander Scherbatiy
On 5/11/2016 1:17 PM, Rajeev Chamyal wrote: Hello All, Please review the updated webrev. Bug : https://bugs.openjdk.java.net/browse/JDK-8147521 Webrev: http://cr.openjdk.java.net/~rchamyal/8147521/webrev.03/ Update: Added a new protected method getpop in PopupFactory.java with a Boolean

Re: [9] Review request for JDK-8147521 [macosx] Internal API Usage: setPopupType used to force creation of heavyweight popup

2016-05-11 Thread Rajeev Chamyal
Hello All, Please review the updated webrev. Bug : https://bugs.openjdk.java.net/browse/JDK-8147521 Webrev: http://cr.openjdk.java.net/~rchamyal/8147521/webrev.03/ Update: Added a new protected method getpop in PopupFactory.java with a Boolean parameter for specifying heavy weight popup.

Re: [9] Review request for JDK-8152981 Double icons with JMenuItem setHorizontalTextPosition on Win 10

2016-05-11 Thread Rajeev Chamyal
Hello Sergey, Please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8152981/webrev.02/ - The empty catch block "catch (Exception e) {}, it will be better to re-throw an exception. Updated the catch code to throw exception. -