Review Request: JDK-7108290 Mouse pressed event missing when canceling a JPopupMenu

Hi, Please review the fix for JDK 9 Bug: https://bugs.openjdk.java.net/browse/JDK-7108290 Webrev: http://cr.openjdk.java.net/~pkbalakr/7108290/webrev.00/ Cause: Mouse pressed event was consumed by JPopupMenu during cancelation of Popup. Except for Metal and Aqua LAF(Mac), this

Re: [9] Review request for JDK-8147521 [macosx] Internal API Usage: setPopupType used to force creation of heavyweight popup

Approved -phil. On 05/24/2016 05:27 AM, Rajeev Chamyal wrote: Hello Phil, Please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8147521/webrev.07/ Changes: Updated the Javadoc. Added the following note: * This method is intended to be used only by PopupFactory sub-classes.

Re: Fix for JDK-6827800 : Default button is activated even when it is invisible

Looks fine to me. On 25.05.16 14:45, Ajit Ghaisas wrote: This the fix for bug : https://bugs.openjdk.java.net/browse/JDK-6827800 Default button is activated even when it is invisible Root cause : Accepting Key press event even if the default button is invisible. Fix

Fix for JDK-6827800 : Default button is activated even when it is invisible

Hi, This the fix for bug : https://bugs.openjdk.java.net/browse/JDK-6827800 Default button is activated even when it is invisible Root cause : Accepting Key press event even if the default button is invisible. Fix : In BasicRootPaneUI.java, accept key press

Re: Review request for 8144161: [TESTBUG] [macosx] Test javax/swing/plaf/basic/BasicComboPopup/7072653/bug7072653.java fails for mac

Changes updated to same webrev.01 > http://cr.openjdk.java.net/~aniyogi/8144161/webrev.01 > With regards, Avik Niyogi > On 25-May-2016, at 2:21 pm, Rajeev Chamyal wrote: > > Looks ok to me. > Can you please add

Re: Review request for 8144161: [TESTBUG] [macosx] Test javax/swing/plaf/basic/BasicComboPopup/7072653/bug7072653.java fails for mac

Looks ok to me. Can you please add specific class imports instead of *. Regards, Rajeev Chamyal From: Avik Niyogi Sent: 25 May 2016 12:53 To: Alexander Scherbatiy Cc: Rajeev Chamyal; swing-dev@openjdk.java.net Subject: Re: Review request for 8144161: [TESTBUG] [macosx] Test

Re: Review request for 8144161: [TESTBUG] [macosx] Test javax/swing/plaf/basic/BasicComboPopup/7072653/bug7072653.java fails for mac

Hi All, Please find updated changes as per inputs received: Bug: https://bugs.openjdk.java.net/browse/JDK-8144161 Webrev: http://cr.openjdk.java.net/~aniyogi/8144161/webrev.01/ With