Re: [9] Review request for 8154431: Allow source and target based validation for the focus transfer between two JComponents.

2016-05-27 Thread Semyon Sadetsky
Hi Phil, please review the updated webrev: http://cr.openjdk.java.net/~ssadetsky/8154431/webrev.02/ I changed the example in the class spec to demonstrate source+target validation and tried to improve spelling. --Semyon On 5/24/2016 1:26 AM, Phil Race wrote: Hi, If the design stays as

Re: Native look and feel on linux [2]

2016-05-27 Thread Yan
> You can put swing.properties file to /lib directory as described here: https://docs.oracle.com/javase/tutorial/uiswing/lookandfeel/plaf.html#properties > > The contents of the file would be: > > swing.systemlaf=com.sun.java.swing.plaf.gtk.GTKLookAndFeel > > This property file will set GTK LaF for

Re: [9] Review request for 8133731: [TEST_BUG] Unmappable in ASCII character such as Thai should be escaped in the regtests targeted for a regular non-I18n runs

2016-05-27 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 5/27/2016 5:21 PM, Alexey Ivanov wrote: Hello Swing team, Could you please review the fix for jdk9: bug: https://bugs.openjdk.java.net/browse/JDK-8133731 webrev: http://cr.openjdk.java.net/~aivanov/8133731/jdk9/webrev.00/ Problem descript

Re: [PATCH] JDK-7169915 : Swing Table Layout bad repaint of the row [REGRESSION] JDK-8133864 : Wrong display, when the document I18n properties is true.

2016-05-27 Thread Alexandr Scherbatiy
The fix should be prepared for the JDK 9 first and only after that be backported to JDK 8u. Could you apply the fix to JDK 9 client repository http://hg.openjdk.java.net/jdk9/client and send the webrev of the fix plus the test (see http://openjdk.java.net/guide/webrevHelp.html). The fix

Re: Review Request: JDK-7108290 Mouse pressed event missing when canceling a JPopupMenu

2016-05-27 Thread Sergey Bylokhov
On 27.05.16 17:15, Alexandr Scherbatiy wrote: Is it consistent with native applications behavior? For example, if try to open a popup in a native Windows application and then press a button, will the native button get the mouse event? The same question is about GTK and Aqua. I am not sure a

Re: [9] Review request for 8133731: [TEST_BUG] Unmappable in ASCII character such as Thai should be escaped in the regtests targeted for a regular non-I18n runs

2016-05-27 Thread Sergey Bylokhov
Looks fine. On 27.05.16 17:21, Alexey Ivanov wrote: Hello Swing team, Could you please review the fix for jdk9: bug: https://bugs.openjdk.java.net/browse/JDK-8133731 webrev: http://cr.openjdk.java.net/~aivanov/8133731/jdk9/webrev.00/ Problem description: The java file is encoded as UTF

[9] Review request for 8133731: [TEST_BUG] Unmappable in ASCII character such as Thai should be escaped in the regtests targeted for a regular non-I18n runs

2016-05-27 Thread Alexey Ivanov
Hello Swing team, Could you please review the fix for jdk9: bug: https://bugs.openjdk.java.net/browse/JDK-8133731 webrev: http://cr.openjdk.java.net/~aivanov/8133731/jdk9/webrev.00/ Problem description: The java file is encoded as UTF-8, it uses Thai character 'ม' directly. In some case

Re: Review Request: JDK-7108290 Mouse pressed event missing when canceling a JPopupMenu

2016-05-27 Thread Alexandr Scherbatiy
On 5/26/2016 8:54 AM, Prem Balakrishnan wrote: Hi, Please review the fix for JDK 9 *Bug:* https://bugs.openjdk.java.net/browse/JDK-7108290 *Webrev:* http://cr.openjdk.java.net/~pkbalakr/7108290/webrev.00/ *Cause:* Mouse pressed ev

Re: Review request for 8144161: [TESTBUG] [macosx] Test javax/swing/plaf/basic/BasicComboPopup/7072653/bug7072653.java fails for mac

2016-05-27 Thread Avik Niyogi
A gentle reminder. Please review the bug fix: http://cr.openjdk.java.net/~aniyogi/8144161/webrev.01/ With Regards, Avik Niyogi > On 25-May-2016, at 2:30 pm, Avik Niyogi wrote: > > Changes updated to same webrev.01 >> http://cr.openjdk.ja