Re: [9] Review request for 8156217 Selected text is shifted on HiDPI display

2016-06-02 Thread Alexandr Scherbatiy
On 5/31/2016 10:40 PM, Phil Race wrote: I applied this and it is *much* better but there still seem to be some tiny quirks. When I drag the mouse to select text down and then up again, as I pass the original mouse click point vertically, repaint seem to jiggle vertically by a pixel. Perhaps

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

2016-06-02 Thread Sergey Bylokhov
On 02.06.16 19:29, Semyon Sadetsky wrote: Should we implement paintTabbedPaneTabBorder() w/o orientation falg also? It is not used in GTK LnF. But this painter extends the public SynthPainter, which can be used by the application. The Nimbus l which extends it implements both methods. --

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

2016-06-02 Thread Semyon Sadetsky
On 6/2/2016 6:53 PM, Sergey Bylokhov wrote: On 02.06.16 18:43, Semyon Sadetsky wrote: GTK LnF draws focus only when a default tab header is used. If custom tab renderer is installed the input focus is not shown. The fix implements the omitted scenario. Should we implement

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

2016-06-02 Thread Sergey Bylokhov
On 02.06.16 18:43, Semyon Sadetsky wrote: GTK LnF draws focus only when a default tab header is used. If custom tab renderer is installed the input focus is not shown. The fix implements the omitted scenario. Should we implement paintTabbedPaneTabBorder() w/o orientation falg also? -- Best

Re: [9] Review request for 8154431: Allow source and target based validation for the focus transfer between two JComponents.

2016-06-02 Thread Sergey Bylokhov
On 02.06.16 18:46, Semyon Sadetsky wrote: On 6/2/2016 12:45 PM, Sergey Bylokhov wrote: There is a tiny typo in the specification: 34 * {@code InputVerifier} and, using {@code> JComponent}'s Is ">" inside {@code } necessary here? yes it is typo. Don't you mind if I remove this upon the push

Re: [9] Review request for 8154431: Allow source and target based validation for the focus transfer between two JComponents.

2016-06-02 Thread Semyon Sadetsky
On 6/2/2016 12:45 PM, Sergey Bylokhov wrote: There is a tiny typo in the specification: 34 * {@code InputVerifier} and, using {@code> JComponent}'s Is ">" inside {@code } necessary here? yes it is typo. Don't you mind if I remove this upon the push to avoid a new review iteration?

[9] Review request for 8157065: There is no the focus border on the selected tab.

2016-06-02 Thread Semyon Sadetsky
Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8157065 webrev: http://cr.openjdk.java.net/~ssadetsky/8157065/webrev.00/ GTK LnF draws focus only when a default tab header is used. If custom tab renderer is installed the input focus is not shown. The fix

Re: [9] Review request for JDK-8146319 JEditorPane function setPage leaves a file lock

2016-06-02 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 6/2/2016 10:26 AM, Rajeev Chamyal wrote: Hello Alexandr, Please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8146319/webrev.02/ Update: Updated code to use try

Re: [9] Review request for JDK-8146319 JEditorPane function setPage leaves a file lock

2016-06-02 Thread Rajeev Chamyal
Hello Alexandr, Please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8146319/webrev.02/ Update: Updated code to use try with resources. Regards, Rajeev Chamyal From: Alexandr Scherbatiy Sent: 01 June 2016 19:30 To: Rajeev Chamyal; Sergey Bylokhov;

Re: [9] Review request for JDK-[TEST_BUG] test/javax/swing/JPopupMenu/8147521/PopupMenuTest.java: compilation failed

2016-06-02 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 6/2/2016 8:13 AM, Rajeev Chamyal wrote: Hello Alexandr, Please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8158358/webrev.01/ Regards, Rajeev Chamyal