Re: Fix for JDK-8065861 : Pressing Esc does not set 'canceled' property of ProgressMonitor

2016-06-09 Thread Ajit Ghaisas
Hi, Thanks Alex for spotting probable exceptions in code changes. I have corrected the code to address them. Here is the updated webrev. Request you to review. http://cr.openjdk.java.net/~aghaisas/8065861/webrev.01/ Regards, Ajit -Original Message- From:

Re: Background is painted taller than needed for superscripted text

2016-06-09 Thread Alexandr Scherbatiy
On 6/8/2016 2:30 PM, Prem Balakrishnan wrote: Hi, Please review fix for JDK9, *Bug:* https://bugs.openjdk.java.net/browse/JDK-8017266 *Webrev:* http://cr.openjdk.java.net/~pkbalakr/8017266/webrev.00/ *Issue:* Background is

Re: [9] Review request for 8156185: JDK-8024858 (long tooltip delay) is not fixed but is easily fixed

2016-06-09 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 6/8/2016 11:08 AM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8156185 webrev: http://cr.openjdk.java.net/~ssadetsky/8156185/webrev.00/ Scan through the

Re: [9] Review request for JDK-8150176 [hidpi] wrong resolution variant of multi-res. image is used for TrayIcon

2016-06-09 Thread Alexandr Scherbatiy
On 6/9/2016 11:55 AM, Rajeev Chamyal wrote: Hello All, Please review the following fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8150176 Webrev: http://cr.openjdk.java.net/~rchamyal/8150176/webrev.00/ Issue: Wrong resolution

Re: [9] Review request for 8158734 JEditorPane.createEditorKitForContentType throws NPE after 6882559

2016-06-09 Thread mikhail cherkasov
On 6/9/2016 12:40 PM, Alexey Ivanov wrote: Except for: 44 static public class MyEditorKit extends EditorKit { Could you please use blessed keyword order: public static? sure, I'll fix it. And in the error message: "Class loader was not been removed for '"… Remove “been” as it's out

Re: [9] Review request for 8158734 JEditorPane.createEditorKitForContentType throws NPE after 6882559

2016-06-09 Thread Alexey Ivanov
Hi Mikhail, Looks fine. Except for: 44 static public class MyEditorKit extends EditorKit { Could you please use blessed keyword order: public static? And in the error message: "Class loader was not been removed for '"… Remove “been” as it's out of its place in this sentence. No need

Re: [9] Review request for 8158734 JEditorPane.createEditorKitForContentType throws NPE after 6882559

2016-06-09 Thread Sergey Bylokhov
Looks fine. On 08.06.16 20:23, mikhail cherkasov wrote: The testcase was modified to check that we removes classloader: http://cr.openjdk.java.net/~mcherkas/8158734/9/webrev.04/ On 6/8/2016 6:00 PM, Sergey Bylokhov wrote: On 08.06.16 17:58, Alexey Ivanov wrote: I think it should. Consider

[9] Review request for JDK-8150176 [hidpi] wrong resolution variant of multi-res. image is used for TrayIcon

2016-06-09 Thread Rajeev Chamyal
Hello All, Please review the following fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8150176 Webrev: http://cr.openjdk.java.net/~rchamyal/8150176/webrev.00/ Issue: Wrong resolution variant image is used in Tray Icon. Fix : Applying the device transform to graphics object to

Re: Programmatically clicking a JLabel in a JList

2016-06-09 Thread Andrej Golovnin
One more solution: MouseEvent clicked = JLabel l = ... for (MouseListener ml : l.getMouseListeners()) { ml.mouseClicked(clicked); } But this solution only works if you don't have subclasses of JLabel which override the #processMouseEvent(MouseEvent)-method. On Thu, Jun 9, 2016 at 7:44