Re: Programmatically clicking a JLabel in a JList

Thanks Andrej. On 6/9/16 1:07 AM, Andrej Golovnin wrote: > One more solution: > > MouseEvent clicked = > JLabel l = ... > > for (MouseListener ml : l.getMouseListeners()) { > ml.mouseClicked(clicked); > } > > But this solution only works if you don't have subclasses of JLabel > which

Re: Review Request JDK-8152419 JColorChooser throws Exception

The fix looks good to me. Thanks, Alexandr. On 6/10/2016 12:39 PM, Prem Balakrishnan wrote: Hi Alexander, Please review updated patch as per review comments. http://cr.openjdk.java.net/~pkbalakr/8152419/webrev.02/ Regards, Prem

Re: [9] Review request for JDK-8159135 [PIT] javax/swing/JMenuItem/8152981/MenuItemIconTest.java always fail

On 6/10/2016 12:36 PM, Rajeev Chamyal wrote: Hello All, Please review the following fix. Bug : https://bugs.openjdk.java.net/browse/JDK-8159135 Webrev : http://cr.openjdk.java.net/~rchamyal/8159135/webrev.00/ Issue :

Re: Review Request JDK-8152419 JColorChooser throws Exception

Hi Alexander, Please review updated patch as per review comments. http://cr.openjdk.java.net/~pkbalakr/8152419/webrev.02/ Regards, Prem From: Alexander Scherbatiy Sent: Tuesday, May 31, 2016 4:04 PM To: Prem Balakrishnan; Sergey Bylokhov; swing-dev@openjdk.java.net Subject: Re:

[9] Review request for JDK-8159135 [PIT] javax/swing/JMenuItem/8152981/MenuItemIconTest.java always fail

Hello All, Please review the following fix. Bug : https://bugs.openjdk.java.net/browse/JDK-8159135 Webrev : http://cr.openjdk.java.net/~rchamyal/8159135/webrev.00/ Issue : MenuItemIconTest fails on windows 10. Cause : In windows 10 menu bar color is white and test checks for red color

Re: Fix for JDK-8065861 : Pressing Esc does not set 'canceled' property of ProgressMonitor

The fix looks good to me. Thanks, Alexandr. On 6/10/2016 8:50 AM, Ajit Ghaisas wrote: Hi, Thanks Alex for spotting probable exceptions in code changes. I have corrected the code to address them. Here is the updated webrev. Request you to review.