The fix looks good to me.
Thanks,
Alexandr.
On 6/15/2016 12:25 PM, Rajeev Chamyal wrote:
Looks fine to me.
Regards,
Rajeev Chamyal
*From:*Prem Balakrishnan
*Sent:* 15 June 2016 14:51
*To:* Rajeev Chamyal; Alexander Scherbatiy; Sergey Bylokhov;
swing-dev@openjdk.java.net
*Subject:* RE: Rev
Looks fine to me.
Regards,
Rajeev Chamyal
From: Prem Balakrishnan
Sent: 15 June 2016 14:51
To: Rajeev Chamyal; Alexander Scherbatiy; Sergey Bylokhov;
swing-dev@openjdk.java.net
Subject: RE: Review Request JDK-8152419 JColorChooser throws
Exception
Hi Rajeev,
Thank you for the r
Hi Rajeev,
Thank you for the review.
Updated patch as per review comment.
http://cr.openjdk.java.net/~pkbalakr/8152419/webrev.03/
Regards,
Prem
From: Rajeev Chamyal
Sent: Wednesday, June 15, 2016 2:38 PM
To: Alexander Scherbatiy; Prem Balakrishnan; Sergey Bylokhov;
swing-dev@open
Hello Prem,
testResult variable is accessed in 2 different threads. It should be declared
volatile.
Regards,
Rajeev Chamyal
From: Alexandr Scherbatiy
Sent: 10 June 2016 19:53
To: Prem Balakrishnan; Sergey Bylokhov; swing-dev@openjdk.java.net
Subject: Re: Review Request JDK-8152419 J
Hi Alexander,
Thank you for the Review.
Why passed shape height is larger that the required superscripted text
height?
In GlyphView:: getPreferredSpan(int axis) method (Refer lines 609 to 611 copied
code snippet below)
...
...
case View.Y_AXIS:
float h = painter.getHeigh
Hi,
Bug :
https://bugs.openjdk.java.net/browse/JDK-8041909
Issue :
Uncaught exceptions in JComboBox listeners cause listener not to receive
events.
If an uncaught exception is thrown inside an action listener for a
JComboBox, that action listener will no longer receive action events
