Re: [OpenJDK 2D-Dev] RFR(L): 8159690: [TESTBUG] Mark headful tests with @key headful.

2016-06-20 Thread Lindenmaier, Goetz
Hi Phil, I'm sorry I got this wrong. I'm not that familiar with the list/repo organization on the jdk side. I'll try to do better next time. Besides the wrong processing of the change, do you have any objections to its content? I'll do a follow-up if so to get it straightened out. Best rega

Re: [OpenJDK 2D-Dev] RFR(L): 8159690: [TESTBUG] Mark headful tests with @key headful.

2016-06-20 Thread Phil Race
It should have been reviewed on 2d as well - I only just saw this. But how I noticed is that as I am syncing jdk9/dev into jdk9/client I saw hundreds (!) of client tests had been updated in the wrong forest. Client test changes and other client changes go into 9/client unless there is a very good

Re: [9] Review request for 8158566 Provide a Swing property to not close toggle menu items on mouse click

2016-06-20 Thread Phil Race
59 * Some times it is required to select several check box menu items from a button 60 * group. In this case it is useful that clicking on one check box menu item 61 * does not close the menu. Such behavior can be controlled by the Look and Feel 62 * property named {@code "CheckBoxM

Re: [9] Review request for 8158566 Provide a Swing property to not close toggle menu items on mouse click

2016-06-20 Thread Alexandr Scherbatiy
Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8158566/webrev.01/ The documentation is added to the JCheckBoxMenuItem and JRadioButtonMenuItem classes. Thanks, Alexandr. On 6/19/2016 9:05 PM, Philip Race wrote: So how does one know of the existence of this p

Re:

2016-06-20 Thread Sergey Bylokhov
Hi, Anton. I am a little bit worried about the change in NimbusStyle.getColorForState(). Before the fix we intentionally never return null from this method, but return DEFAULT_COLOR which has this javadoc: /** * The Color to return from getColorForState if it would otherwise have