Re: [9] Review request for 8057791: Selection in JList is drawn with wrong colors in Nimbus L

2016-06-21 Thread Anton Litvinov
Hello Sergey and Semyon, Sergey, thank you for review of this fix. In the 1st version of the fix I decided to return "null", because at least one implementation of "javax.swing.plaf.synth.SynthStyle" which is "sun.swing.plaf.synth.DefaultSynthStyle" returns "null" from its implementation of

Re: [9] Review Request JDK-8147648 [hidpi] multiresolution image: wrong resolution variant is used as icon in the Unity panel

2016-06-21 Thread Alexandr Scherbatiy
On 6/21/2016 12:16 PM, Rajeev Chamyal wrote: Hello All, Please review the following webrev. Webrev: http://cr.openjdk.java.net/~rchamyal/8147648/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8147648 Issue: Wrong

Re: [9] Review request for 7020860: BasicTreeUI contains getters/setters with unclear spec

2016-06-21 Thread Alexandr Scherbatiy
On 6/14/2016 5:37 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-7020860 webrev: http://cr.openjdk.java.net/~ssadetsky/7020860/webrev.00/ The methods mentioned in JIRA are not getters/setters according to JavaBeans specs,

Re: [9] RFR JDK-8159068:The rendering of JTable is broken

2016-06-21 Thread Alexandr Scherbatiy
On 6/21/2016 1:58 PM, Prasanta Sadhukhan wrote: On 6/21/2016 4:14 PM, Alexandr Scherbatiy wrote: On 6/20/2016 8:10 AM, prasanta sadhukhan wrote: Gentle reminder for review!! Regards Prasanta On 6/13/2016 4:31 PM, prasanta sadhukhan wrote: On 6/13/2016 12:51 PM, prasanta sadhukhan wrote:

Re: Review Request JDK-8159152 Ctrl+F6, Ctrl+F5 doesn't work for iconified InternalFrame

2016-06-21 Thread Alexandr Scherbatiy
On 6/20/2016 5:59 AM, Rajeev Chamyal wrote: Hello Alexandr, TestJInternalFrameMinimize test passes after this fix. Could you also check that the initial issue where the call setComponentOrderCheckingEnabled(true/false) has been added to the

Re: [9] RFR JDK-8159068:The rendering of JTable is broken

2016-06-21 Thread Prasanta Sadhukhan
On 6/21/2016 4:14 PM, Alexandr Scherbatiy wrote: On 6/20/2016 8:10 AM, prasanta sadhukhan wrote: Gentle reminder for review!! Regards Prasanta On 6/13/2016 4:31 PM, prasanta sadhukhan wrote: On 6/13/2016 12:51 PM, prasanta sadhukhan wrote: Hi All, Please review a fix for jdk9 where it

Re: [9] RFR JDK-8159068:The rendering of JTable is broken

2016-06-21 Thread Alexandr Scherbatiy
On 6/20/2016 8:10 AM, prasanta sadhukhan wrote: Gentle reminder for review!! Regards Prasanta On 6/13/2016 4:31 PM, prasanta sadhukhan wrote: On 6/13/2016 12:51 PM, prasanta sadhukhan wrote: Hi All, Please review a fix for jdk9 where it was seen that if we try to select some rows in a

[9] Review Request JDK-8147648 [hidpi] multiresolution image: wrong resolution variant is used as icon in the Unity panel

2016-06-21 Thread Rajeev Chamyal
Hello All, Please review the following webrev. Webrev: http://cr.openjdk.java.net/~rchamyal/8147648/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8147648 Issue: Wrong resolution variant is used as icon in the Unity panel. Cause: The screen transforms are not applied to

Re: [OpenJDK 2D-Dev] RFR(L): 8159690: [TESTBUG] Mark headful tests with @key headful.

2016-06-21 Thread Lindenmaier, Goetz
Hi Phil, I'm sorry I got this wrong. I'm not that familiar with the list/repo organization on the jdk side. I'll try to do better next time. Besides the wrong processing of the change, do you have any objections to its content? I'll do a follow-up if so to get it straightened out. Best