Re: [9] Review request for 8158566 Provide a Swing property to not close toggle menu items on mouse click

+1 .. please file a CCC. -phil. On 6/24/16, 5:33 AM, Alexandr Scherbatiy wrote: Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8158566/webrev.02 On 6/20/2016 10:55 PM, Phil Race wrote: 59 * Some times it is required to select several check box menu items from a but

Re: [9] Review request for JDK-8158325: [macosx]Memory leak in com.apple.laf.ScreenMenu

The webrev link: http://cr.openjdk.java.net/~alexsch/robin.stevens/8158325/webrev.00/ The fix looks good to me. Thanks, Alexandr. On 6/23/2016 7:08 PM, Robin Stevens wrote: Hello all, attached is a webrev for issue JDK-8158325 Memory leak in com.apple.laf.ScreenMenu: removed JMenuI

Re: [9] Review request for 8158566 Provide a Swing property to not close toggle menu items on mouse click

Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8158566/webrev.02 On 6/20/2016 10:55 PM, Phil Race wrote: 59 * Some times it is required to select several check box menu items from a button 60 * group. In this case it is useful that clicking on one check box menu i

Re: [9] Review request for 8160248 Dragged internal frame leaves artifacts for floating point ui scale

Hi Alexander, Test fails on my local Ubuntu 14 because the image grabs shadow from the left border of the frame. Probably this is a test issue and you need to shift image window to the left by 1px. --Semyon On 6/24/2016 2:27 PM, Alexandr Scherbatiy wrote: Hello, Could you review the fi

Re: [9] RFR JDK-8159068:The rendering of JTable is broken

The fix looks good to me. Thanks, Alexandr. On 6/24/2016 12:37 PM, Prasanta Sadhukhan wrote: On 6/24/2016 1:41 PM, Alexandr Scherbatiy wrote: On 6/24/2016 10:04 AM, Prasanta Sadhukhan wrote: Hi Alexandr, Thanks for your suggestion. Have modified as per the comment to decide based on sele

[9] Review request for 8160248 Dragged internal frame leaves artifacts for floating point ui scale

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8160248 webrev: http://cr.openjdk.java.net/~alexsch/8160248/webrev.00 SunGraphics2D.hitClip() does not guarantee that it returns false for non-intersected areas. This exactly happens for rectangles when floa

Re: RfR JDK-8145207 [macosx] JList, VO can't access non-visible list items

Hi Pete, That’s a problem, yes. Though, even without that action functionality, JList becomes navigate-able with VO (am I right?) that is quite the difference to what it is now. So, if you don’t find any way to make it into jdk8, a partial fix would also be valuable. Thanks, Anton. > On 24

Re: [9] RFR JDK-8159068:The rendering of JTable is broken

On 6/24/2016 1:41 PM, Alexandr Scherbatiy wrote: On 6/24/2016 10:04 AM, Prasanta Sadhukhan wrote: Hi Alexandr, Thanks for your suggestion. Have modified as per the comment to decide based on selected row. 8081491 testcase and SwingSet2 JTa

Re: [9] Review request for 8152968: JTree Collapse Buttons Clipped Off Under GTK

The fix looks good to me. Thanks, Alexandr. On 6/23/2016 6:44 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8152968 webrev: http://cr.openjdk.java.net/~ssadetsky/8152968/webrev.00/ GTK lib paints the expander icon bigger t

Re: [9] RFR JDK-8159068:The rendering of JTable is broken

On 6/24/2016 10:04 AM, Prasanta Sadhukhan wrote: Hi Alexandr, Thanks for your suggestion. Have modified as per the comment to decide based on selected row. 8081491 testcase and SwingSet2 JTable demo works. Please review modified webrev: http

Re: [9] RFR JDK-8159068:The rendering of JTable is broken

Hi Alexandr, Thanks for your suggestion. Have modified as per the comment to decide based on selected row. 8081491 testcase and SwingSet2 JTable demo works. Please review modified webrev: http://cr.openjdk.java.net/~psadhukhan/8159068/webrev.