[9] Review request for 8160054: The FileChooser didn't displayed large font with GTK LAF option.

2016-06-27 Thread Semyon Sadetsky
Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8160054 webrev: http://cr.openjdk.java.net/~ssadetsky/8160054/webrev.00/ The root case is GTK LnF does not allow to change its default fonts. The proposed solution let's to use LnF font properties to change the

Re: [9] Review request for 8158566 Provide a Swing property to not close toggle menu items on mouse click

2016-06-27 Thread Phil Race
On 06/27/2016 04:42 AM, Semyon Sadetsky wrote: I left the suggested phrase as: "* Note: some {@code L}s may ignore this property. All built-in L inherit this behaviour." "L" produces compilation error because the "&" is a prefix for special symbols codes. You need to replace it with ""

Re: [9] Review request for 8158566 Provide a Swing property to not close toggle menu items on mouse click

2016-06-27 Thread Semyon Sadetsky
On 6/27/2016 12:47 PM, Alexander Scherbatiy wrote: On 27/06/16 10:56, Semyon Sadetsky wrote: On 6/24/2016 3:33 PM, Alexandr Scherbatiy wrote: Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8158566/webrev.02 On 6/20/2016 10:55 PM, Phil Race wrote: 59 * Some times

Re: [9] Review Request JDK-8147648 [hidpi] multiresolution image: wrong resolution variant is used as icon in the Unity panel

2016-06-27 Thread Rajeev Chamyal
Hello Sergey, Could you please review this fix. http://cr.openjdk.java.net/~rchamyal/8147648/webrev.01/ Regards, Rajeev Chamyal From: Alexandr Scherbatiy Sent: 22 June 2016 15:46 To: Rajeev Chamyal; Sergey Bylokhov; swing-dev@openjdk.java.net Subject: Re: [9] Review Request

Re: [9] Review request for 8160248 Dragged internal frame leaves artifacts for floating point ui scale

2016-06-27 Thread Alexander Scherbatiy
On 24/06/16 15:56, Semyon Sadetsky wrote: Hi Alexander, Test fails on my local Ubuntu 14 because the image grabs shadow from the left border of the frame. Probably this is a test issue and you need to shift image window to the left by 1px. This issue is reproduced with ui scale 2 and is

Re: [9] Review request for 8158566 Provide a Swing property to not close toggle menu items on mouse click

2016-06-27 Thread Alexander Scherbatiy
On 27/06/16 10:56, Semyon Sadetsky wrote: On 6/24/2016 3:33 PM, Alexandr Scherbatiy wrote: Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8158566/webrev.02 On 6/20/2016 10:55 PM, Phil Race wrote: 59 * Some times it is required to select several check box menu

Re: [9] RFR JDK-8159068:The rendering of JTable is broken

2016-06-27 Thread Rajeev Chamyal
Looks good to me.   Regards, Rajeev Chamyal   From: Alexandr Scherbatiy Sent: 24 June 2016 17:01 To: Prasanta Sadhukhan; Rajeev Chamyal; swing-dev@openjdk.java.net Subject: Re: [9] RFR JDK-8159068:The rendering of JTable is broken   The fix looks good to me. Thanks, Alexandr. On

Re: [9] Review request for 8158566 Provide a Swing property to not close toggle menu items on mouse click

2016-06-27 Thread Semyon Sadetsky
On 6/24/2016 3:33 PM, Alexandr Scherbatiy wrote: Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8158566/webrev.02 On 6/20/2016 10:55 PM, Phil Race wrote: 59 * Some times it is required to select several check box menu items from a button 60 * group. In this case