Re: 8160438: [PIT][macosx] [TEST_BUG] javax/swing/plaf/nimbus/8057791/bug8057791.java fails

Hi Prasanta, Kindly request you to review the webrev raised with inputs taken from reviewers in the mail trail. Thank you in advance. With Regards, Avik Niyogi > On 15-Jul-2016, at 11:37 am, Avik Niyogi wrote: > > I will ask Prasanta to review since it is not a native code change. > >> On 15-J

Re: 8160438: [PIT][macosx] [TEST_BUG] javax/swing/plaf/nimbus/8057791/bug8057791.java fails

Another gentle reminder, please review my code changes. Thank you in advance. With Regards, Avik Niyogi > On 14-Jul-2016, at 8:46 pm, Alexandr Scherbatiy > wrote: > > > The fix looks good to me. > > Thanks, > Alexandr. > > On 7/14/2016 9:53 AM, Avik Niyogi wrote: >> Hi All, >> Please find my

Re: RfR JDK-8145207 [macosx] JList, VO can't access non-visible list items

Hi Alexandr, Thanks very much for the review. I updated the webrev. See http://cr.openjdk.java.net/~ptbrunet/JDK-8145207/webrev.01/ >From your separate email you suggested the following in order to provide the AccessibleAction interface without changing the public API of JList.AccessibleJList.Ac

Re: [9] Review request for 8160054: The FileChooser didn't displayed large font with GTK LAF option.

On 6/27/2016 9:23 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8160054 webrev: http://cr.openjdk.java.net/~ssadetsky/8160054/webrev.00/ The root case is GTK LnF does not allow to change its default fonts. The proposed solution le

Re: Swing Dev>[9] Review Request JDK-8158918 setExtendedState(1) for maximized Frame results in state==7

On 7/14/2016 1:18 PM, Rajeev Chamyal wrote: Hello All, Please review the following webrev. Bug: https://bugs.openjdk.java.net/browse/JDK-8158918 Webrev: http://cr.openjdk.java.net/~rchamyal/8158918/webrev.00/ Issue: Frame setExten

Re: 8160438: [PIT][macosx] [TEST_BUG] javax/swing/plaf/nimbus/8057791/bug8057791.java fails

The fix looks good to me. Thanks, Alexandr. On 7/14/2016 9:53 AM, Avik Niyogi wrote: Hi All, Please find my webrev below for review which includes changes as perceived from inputs provided. http://cr.openjdk.java.net/~aniyogi/8160438/webrev.02/

Re: [9] Review Request JDK-8147648 [hidpi] multiresolution image: wrong resolution variant is used as icon in the Unity panel

Hi Rajeev, I have added 1px border to the icon in your test: private static BufferedImage generateImage(int scale, Color c) { int x = SZ * scale; BufferedImage img = new BufferedImage(x, x, BufferedImage.TYPE_INT_RGB); Graphics g = img.getGraphics(); if (g !

Swing Dev>[9] Review Request JDK-8158918 setExtendedState(1) for maximized Frame results in state==7

Hello All, Please review the following webrev. Bug: https://bugs.openjdk.java.net/browse/JDK-8158918 Webrev: http://cr.openjdk.java.net/~rchamyal/8158918/webrev.00/ Issue: Frame setExtendedState = 1 on a maximized frame is not working. Cause: Issue is due to ::ShowWindow API call add

[ping] RFR(L): 8160974: [TESTBUG] Mark more headful tests with @key headful.

Hi, could someone please have a look at this? It's L, but the change is only one line in a lot of tests ... Thanks! Goetz. > -Original Message- > From: Lindenmaier, Goetz > Sent: Donnerstag, 7. Juli 2016 17:01 > To: 'awt-...@openjdk.java.net' ; swing- > d...@openjdk.java.net; '2d-dev' <

Re: [9] Review Request JDK-8147648 [hidpi] multiresolution image: wrong resolution variant is used as icon in the Unity panel

Hello All, Gentle reminder. Please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8147648/webrev.02/ Update: simplified the test. Regards, Rajeev Chamyal From: Alexandr Scherbatiy Sent: 22 June 2016 15:46 To: Rajeev Chamyal; Sergey Bylokhov; HYPERLINK "mailto:sw