Re: [OpenJDK 2D-Dev] RFR(L): 8160974: [TESTBUG] Mark more headful tests with @key headful.

Hi Volker, thanks for that thorough review, the wrong \ is a really good catch! I did'nt upload a new webrev, but maybe the incremental diff Is useful: http://cr.openjdk.java.net/~goetz/wr16/8160974-headful/webrev.02/incremental_fixes.patch Best regards, Goetz. > -Original

Re: [9] Review request for 8160087: Change IOOBE to warning in the scenarios when it had not being thrown before the JDK-8078514

On 7/20/2016 2:29 PM, Alexandr Scherbatiy wrote: On 7/20/2016 10:18 AM, Semyon Sadetsky wrote: On 7/19/2016 4:06 PM, Alexandr Scherbatiy wrote: On 7/19/2016 2:56 PM, Semyon Sadetsky wrote: On 19.07.2016 14:20, Alexandr Scherbatiy wrote: The fix prints the warning method in case of wrong

Re: [OpenJDK 2D-Dev] RFR(L): 8160974: [TESTBUG] Mark more headful tests with @key headful.

Hi Götz, your change looks good. Thanks a lot for cleaning up all these tests! I only found one problem which you should fix: test/java/awt/Frame/MiscUndecorated/RepaintTest.java @@ -1,6 +1,6 @@ -/* +\/* Seems like there's an extra backslash at the beginning of the first line. You may also

Re: [9] Fix for JDK-7096375 : Swing ignores first click after decreasing system's time

Hi, Added throwing exception in case create UI or dispose UI fails. Here is the updated webrev: http://cr.openjdk.java.net/~aghaisas/7096375/webrev.02/ Regards, Ajit -Original Message- From: Alexandr Scherbatiy Sent: Wednesday, July 20, 2016 5:13 PM To: Ajit Ghaisas;

Re: 8161470: [TEST_BUG] Failure javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java

The fix looks good to me. Thanks, Alexandr. On 7/20/2016 9:34 AM, Rajeev Chamyal wrote: Looks fine to me. Regards, Rajeev Chamyal *From:*Avik Niyogi *Sent:* 20 July 2016 11:52 *To:* Rajeev Chamyal *Cc:* Praveen Srivastava; Alexander Scherbatiy; swing-dev@openjdk.java.net *Subject:* Re:

Re: [9] Fix for JDK-7096375 : Swing ignores first click after decreasing system's time

On 7/20/2016 1:50 PM, Ajit Ghaisas wrote: Hi, I have modified the test as per suggestion. Please review the updated webrev : http://cr.openjdk.java.net/~aghaisas/7096375/webrev.01/ It is better to rethrow the exceptions during UI creation and disposing because it also means

Re: [9] Review request for 8160087: Change IOOBE to warning in the scenarios when it had not being thrown before the JDK-8078514

On 7/20/2016 10:18 AM, Semyon Sadetsky wrote: On 7/19/2016 4:06 PM, Alexandr Scherbatiy wrote: On 7/19/2016 2:56 PM, Semyon Sadetsky wrote: On 19.07.2016 14:20, Alexandr Scherbatiy wrote: The fix prints the warning method in case of wrong row sorter usage. How often this can happen? Could

Re: [9] Review Request: 8161664: Memory leak in com.apple.laf.AquaProgressBarUI: removed progress bar still referenced

The fix looks good to me. Thanks, Alexandr. On 7/20/2016 11:37 AM, Robin Stevens wrote: Hello, please review this patch for issue JDK-8161664: Bug: https://bugs.openjdk.java.net/browse/JDK-8161664 Patch: http://cr.openjdk.java.net/~rstevens/8161664/webrev.00/

Re: [9] Fix for JDK-7096375 : Swing ignores first click after decreasing system's time

Hi, I have modified the test as per suggestion. Please review the updated webrev : http://cr.openjdk.java.net/~aghaisas/7096375/webrev.01/ Regards, Ajit -Original Message- From: Alexandr Scherbatiy Sent: Tuesday, July 19, 2016 2:33 PM To: Ajit Ghaisas;

[9] Review Request: 8161664: Memory leak in com.apple.laf.AquaProgressBarUI: removed progress bar still referenced

Hello, please review this patch for issue JDK-8161664: Bug: https://bugs.openjdk.java.net/browse/JDK-8161664 Patch: http://cr.openjdk.java.net/~rstevens/8161664/webrev.00/ The problem is that in certain scenarios, the Timer in the Animator of the AquaProgressBarUI does not get stopped when the

Re: [9] Review request for 8160087: Change IOOBE to warning in the scenarios when it had not being thrown before the JDK-8078514

On 7/19/2016 4:06 PM, Alexandr Scherbatiy wrote: On 7/19/2016 2:56 PM, Semyon Sadetsky wrote: On 19.07.2016 14:20, Alexandr Scherbatiy wrote: The fix prints the warning method in case of wrong row sorter usage. How often this can happen? Could the large number of the messages overflow a

Re: 8161470: [TEST_BUG] Failure javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java

Looks fine to me. Regards, Rajeev Chamyal From: Avik Niyogi Sent: 20 July 2016 11:52 To: Rajeev Chamyal Cc: Praveen Srivastava; Alexander Scherbatiy; swing-dev@openjdk.java.net Subject: Re: 8161470: [TEST_BUG] Failure javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java Hi

Re: 8161470: [TEST_BUG] Failure javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java

Hi Rajeev, Updated on same webrev due to single line change. > On 20-Jul-2016, at 11:41 am, Rajeev Chamyal wrote: > > Hello Avik, > > Line 67 can be removed from test. > > Regards, > Rajeev Chamyal > From: Avik Niyogi > Sent: 20 July 2016 11:30 > To: Rajeev

Re: 8161470: [TEST_BUG] Failure javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java

Updated on the same webrev due to one line change. With Regards, Avik Niyogi > On 20-Jul-2016, at 11:41 am, Rajeev Chamyal wrote: > > Hello Avik, > > Line 67 can be removed from test. > > Regards, > Rajeev Chamyal > From: Avik Niyogi > Sent: 20 July 2016 11:30 >

Re: 8161470: [TEST_BUG] Failure javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java

A gentle reminder, please review my code changes. With Regards, Avik Niyogi > On 19-Jul-2016, at 1:31 pm, Alexandr Scherbatiy > wrote: > > > The fix looks good to me. > > Thanks, > Alexandr. > > On 7/19/2016 9:45 AM, Avik Niyogi wrote: >> Hi All, >> >>