Re: [OpenJDK 2D-Dev] [9] Review request for 8151303 [macosx] [hidpi] JButton's low-res. icon is visible when clicking on it

2016-08-11 Thread Jim Graham
Hi Alexandr, Should something be done to transfer the array of sizes to the new instance if the source is an MRCI? Perhaps a special case for MRCI as well that calls mrciInstance.map(mapper) instead of constructing a brand new object from scratch? ...jim On 08/11/20

Re: [9] Review request for 8163124 Add floating point API support to javax.swing.text.Caret

2016-08-11 Thread Alexandr Scherbatiy
I am sorry. The JTextComponent.viewToModel(Point) method returns the closest location for the provided point. If the caret position is N.25 the distance to the right character is 0.25 and to the left one is greater than 0.75. Even in for the worst case the distance to the right character is l

Re: [8] Review Request: 8161664: Memory leak in com.apple.laf.AquaProgressBarUI: removed progress bar still referenced

2016-08-11 Thread Alexandr Scherbatiy
The backport looks good to me. Thanks, Alexandr. On 8/11/2016 12:14 AM, Robin Stevens wrote: Hello, please review the backport of the fix for 8161664 to 8u-dev. Approval for the backport: http://mail.openjdk.java.net/pipermail/jdk8u-dev/2016-August/005781.html Bug: https://bugs.openjdk.jav

Re: [OpenJDK 2D-Dev] [9] Review request for 8151303 [macosx] [hidpi] JButton's low-res. icon is visible when clicking on it

2016-08-11 Thread Alexander Scherbatiy
Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8151303/webrev.03 MultiResolutionToolkitImage handing is added to the MultiResolutionCachedImage.map() method. Thanks, Alexandr. On 11/08/16 01:46, Jim Graham wrote: Ah, yes, only ToolkitImages can be "not yet loaded" i