Re: [9] Review request for 8156217 Selected text is shifted on HiDPI display

2016-08-23 Thread Philip Race
This *really* needs someone else who knows the ins and outs of Swing to review it. The words on the model2View ones like * Converts the given place in the view coordinate system * to the nearest representative location in the model. make it sounds like absolute precision isn't what is needed

Re: [9] Review request for 8163167: [PIT] javax/swing/JTextArea/ScrollbarFlicker/ScrollFlickerTest.java always fail

2016-08-23 Thread Semyon Sadetsky
On 8/23/2016 9:29 PM, Sergey Bylokhov wrote: On 23.08.16 20:57, Semyon Sadetsky wrote: Just to clarify, on what L the bug is reproduced? Why we call the listener 6 times when we set the size of scroll only once? I tried to print the bounds of the viewport in the listener and it seems that

Re: [9] Review request for 8163167: [PIT] javax/swing/JTextArea/ScrollbarFlicker/ScrollFlickerTest.java always fail

2016-08-23 Thread Sergey Bylokhov
On 23.08.16 20:57, Semyon Sadetsky wrote: Just to clarify, on what L the bug is reproduced? Why we call the listener 6 times when we set the size of scroll only once? I tried to print the bounds of the viewport in the listener and it seems that they are the same most of the time: bounds =

Re: [9] Review request for 8163167: [PIT] javax/swing/JTextArea/ScrollbarFlicker/ScrollFlickerTest.java always fail

2016-08-23 Thread Semyon Sadetsky
On 8/23/2016 8:35 PM, Sergey Bylokhov wrote: On 23.08.16 20:29, Semyon Sadetsky wrote: On 8/23/2016 8:00 PM, Sergey Bylokhov wrote: Just to clarify, on what L the bug is reproduced? Why we call the listener 6 times when we set the size of scroll only once? I tried to print the bounds of the

Re: [9] Review request for 8163167: [PIT] javax/swing/JTextArea/ScrollbarFlicker/ScrollFlickerTest.java always fail

2016-08-23 Thread Sergey Bylokhov
On 23.08.16 20:29, Semyon Sadetsky wrote: On 8/23/2016 8:00 PM, Sergey Bylokhov wrote: Just to clarify, on what L the bug is reproduced? Why we call the listener 6 times when we set the size of scroll only once? I tried to print the bounds of the viewport in the listener and it seems that they

Re: [9] Review request for 8163167: [PIT] javax/swing/JTextArea/ScrollbarFlicker/ScrollFlickerTest.java always fail

2016-08-23 Thread Semyon Sadetsky
On 8/23/2016 8:00 PM, Sergey Bylokhov wrote: Just to clarify, on what L the bug is reproduced? Why we call the listener 6 times when we set the size of scroll only once? I tried to print the bounds of the viewport in the listener and it seems that they are the same most of the time: bounds =

Re: [9] Review request for 8163167: [PIT] javax/swing/JTextArea/ScrollbarFlicker/ScrollFlickerTest.java always fail

2016-08-23 Thread Sergey Bylokhov
Just to clarify, on what L the bug is reproduced? Why we call the listener 6 times when we set the size of scroll only once? I tried to print the bounds of the viewport in the listener and it seems that they are the same most of the time: bounds = java.awt.Rectangle[x=2,y=2,width=15,height=46]

Re: [9] Review request for 8163167: [PIT] javax/swing/JTextArea/ScrollbarFlicker/ScrollFlickerTest.java always fail

2016-08-23 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 23/08/16 11:40, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8163167 webrev: http://cr.openjdk.java.net/~ssadetsky/8163167/webrev.00/ The cause of this test bug is revalidating

Re: 8163161: [PIT][TEST_BUG] increase timeout in javax/swing/plaf/nimbus/8057791/bug8057791.java

2016-08-23 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 23/08/16 10:38, Avik Niyogi wrote: Hi All, Kindly review the fix for JDK9. *Bug: https://bugs.openjdk.java.net/browse/JDK-8163161* *Webrev: http://cr.openjdk.java.net/~aniyogi/8163161/webrev.00/

[9] Review request for 8163167: [PIT] javax/swing/JTextArea/ScrollbarFlicker/ScrollFlickerTest.java always fail

2016-08-23 Thread Semyon Sadetsky
Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8163167 webrev: http://cr.openjdk.java.net/~ssadetsky/8163167/webrev.00/ The cause of this test bug is revalidating JScrollPane layout may take various number of iterations on different L To fix the test the

8163161: [PIT][TEST_BUG] increase timeout in javax/swing/plaf/nimbus/8057791/bug8057791.java

2016-08-23 Thread Avik Niyogi
Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8163161 Webrev: http://cr.openjdk.java.net/~aniyogi/8163161/webrev.00/ Issue: This test