Re: [9] Review request for 8163124 Add floating point API support to javax.swing.text.Caret

2016-08-24 Thread Philip Race
On 8/24/16, 9:45 AM, Alexander Scherbatiy wrote: On 17/08/16 22:49, Phil Race wrote: Sorry, but I have had some trouble trying to picture this. If the caret is between "b" and "c", being off by a fractional value seems unlikely to make it jump to between "a" and "b". It might now "round" to

Re: [9] Review request for 8163124 Add floating point API support to javax.swing.text.Caret

2016-08-24 Thread Alexander Scherbatiy
On 17/08/16 22:49, Phil Race wrote: Sorry, but I have had some trouble trying to picture this. If the caret is between "b" and "c", being off by a fractional value seems unlikely to make it jump to between "a" and "b". It might now "round" to somewhere in the trailing pixel of "b" but nowhere

Re: [9] Review request for 8163167: [PIT] javax/swing/JTextArea/ScrollbarFlicker/ScrollFlickerTest.java always fail

2016-08-24 Thread Semyon Sadetsky
On 8/24/2016 6:33 PM, Sergey Bylokhov wrote: On 23.08.16 22:06, Semyon Sadetsky wrote: Yes, we can validate/revalidate do some other stuff internally, but it is unclear why we call the listener when actually nothing was changed from the user point of view(bounds are the same). I see that in

Re: [9] Review request for 8163167: [PIT] javax/swing/JTextArea/ScrollbarFlicker/ScrollFlickerTest.java always fail

2016-08-24 Thread Sergey Bylokhov
On 23.08.16 22:06, Semyon Sadetsky wrote: Yes, we can validate/revalidate do some other stuff internally, but it is unclear why we call the listener when actually nothing was changed from the user point of view(bounds are the same). I see that in the code we have some check to block such noop

Re: 8163161: [PIT][TEST_BUG] increase timeout in javax/swing/plaf/nimbus/8057791/bug8057791.java

2016-08-24 Thread Rajeev Chamyal
Looks good to me. Regards, Rajeev Chamyal From: Avik Niyogi Sent: 24 August 2016 14:14 To: Rajeev Chamyal Cc: Alexander Scherbatiy; swing-dev@openjdk.java.net Subject: Re: 8163161: [PIT][TEST_BUG] increase timeout in javax/swing/plaf/nimbus/8057791/bug8057791.java Hi All, A gentle

Re: 8163161: [PIT][TEST_BUG] increase timeout in javax/swing/plaf/nimbus/8057791/bug8057791.java

2016-08-24 Thread Avik Niyogi
Hi All, A gentle reminder, please review my code change. With Regards, Avik Niyogi > On 23-Aug-2016, at 2:28 pm, Alexander Scherbatiy > wrote: > > The fix looks good to me. > > Thanks, > Alexandr. > > On 23/08/16 10:38, Avik Niyogi wrote: >> Hi All, >> >>