Re: Review Request: JDK-8009477 :PageUp and PageDown keyboard buttons don't move slider indicator to next minor tick

2016-09-05 Thread Prem Balakrishnan
Hi Alexandr, Thank you for the feedback. I have updated patch as per review comments. http://cr.openjdk.java.net/~pkbalakr/8009477/webrev.01/ Regards, Prem From: Alexandr Scherbatiy Sent: Monday, September 05, 2016 3:50 PM To: Prem Balakrishnan; Sergey Bylokhov; Rajeev Chamyal;

8163274: [TEST_BUG][macosx] apparent regression: javax/swing/JColorChooser/Test7194184.java

2016-09-05 Thread Avik Niyogi
Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8163274 Webrev: http://cr.openjdk.java.net/~aniyogi/8163274/webrev.00/ Issue: This test javax/swin

Re: [9] Review request for 8160054: The FileChooser didn't displayed large font with GTK LAF option.

2016-09-05 Thread Sergey Bylokhov
On 05.09.16 19:11, Semyon Sadetsky wrote: On 9/5/2016 6:55 PM, Sergey Bylokhov wrote: On 02.09.16 12:50, Alexandr Scherbatiy wrote: The fix looks good to me. Probably the comment between .00 and .01 should be updated also? "// if font property got different value then return it" I will chan

Re: [9] Review request for 8160054: The FileChooser didn't displayed large font with GTK LAF option.

2016-09-05 Thread Semyon Sadetsky
On 9/5/2016 6:55 PM, Sergey Bylokhov wrote: On 02.09.16 12:50, Alexandr Scherbatiy wrote: The fix looks good to me. Probably the comment between .00 and .01 should be updated also? "// if font property got different value then return it" I will change it to "got a value" upon the push if you

Re: [9] Review request for 8160054: The FileChooser didn't displayed large font with GTK LAF option.

2016-09-05 Thread Sergey Bylokhov
On 02.09.16 12:50, Alexandr Scherbatiy wrote: The fix looks good to me. Probably the comment between .00 and .01 should be updated also? "// if font property got different value then return it" On 9/2/2016 11:41 AM, Semyon Sadetsky wrote: On 7/14/2016 6:31 PM, Alexandr Scherbatiy wrote: O

Re: [9] Review request for 8165234 Provide a way to not close toggle menu items on mouse click on component level

2016-09-05 Thread Alexandr Scherbatiy
Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8165234/webrev.01 On 9/2/2016 9:59 PM, Phil Race wrote: Seems fine except for a grammatical issue in the javadoc {@code true}. Setting the property to {@code false} either to {@literal L&F} I think you mean ".. either

Re: Review Request: JDK-8009477 :PageUp and PageDown keyboard buttons don't move slider indicator to next minor tick

2016-09-05 Thread Alexandr Scherbatiy
On 9/2/2016 1:00 PM, Prem Balakrishnan wrote: Hi Alexandr, Yes true, Setting getSnapToTicks() true will set block increment to minor/majorTickSpacing. But enabling getSanpToTicks will Disable Unit Increment (scrollByUnit using Up/Down Arrow keys ) It works in the following way befor

Re: Review Request for 8163261: regression on Linux: java/awt/LightweightDispatcher/LWDispatcherMemoryLeakTest.java

2016-09-05 Thread Alexandr Scherbatiy
On 9/2/2016 7:18 AM, Ambarish Rapte wrote: Hi Alex, Thanks for the review comments, Yes, we can use thePainterMultiResolutionCachedImage.class object as a key in the PainterMultiResolutionCachedImage.getResolutionVariant() method. But there is below concern, 1.If PainterMu