Re: 8163274: [TEST_BUG][macosx] apparent regression: javax/swing/JColorChooser/Test7194184.java

2016-09-06 Thread Rajeev Chamyal
Looks good to me. Regards, Rajeev Chamyal From: Alexandr Scherbatiy Sent: 06 September 2016 16:16 To: Avik Niyogi; Rajeev Chamyal; swing-dev@openjdk.java.net Subject: Re: 8163274: [TEST_BUG][macosx] apparent regression: javax/swing/JColorChooser/Test7194184.java The fix looks good

Re: Review Request for 8163261: regression on Linux: java/awt/LightweightDispatcher/LWDispatcherMemoryLeakTest.java

2016-09-06 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 9/6/2016 6:21 PM, Ambarish Rapte wrote: Hi Alex, 1.There will be only one key value pair entry in the /cacheMap/. The CachedPainter.paint0() method uses getClass() as a key for the cacheMap. At least there should be more than 1 key

Re: Review Request for 8163261: regression on Linux: java/awt/LightweightDispatcher/LWDispatcherMemoryLeakTest.java

2016-09-06 Thread Ambarish Rapte
Hi Alex, 1. There will be only one key value pair entry in the cacheMap. The CachedPainter.paint0() method uses getClass() as a key for the cacheMap. At least there should be more than 1 key (getClass() + PainterMultiResolutionCachedImage.class). Sorry for the confusion here, I

Re: [9] Review request for 8165485 Bad rendering of Swing UI controls with Motif L on HiDPI display

2016-09-06 Thread Sergey Bylokhov
It seems that there are some small artifacts on some of the components, please take a look to the corners of the selected checkbox. In 1x the corners have correct edges but in x2,x4 there are some missing pixels. Similar issue is in the text area(take a look to the white border). On 06.09.16

Re: 8163274: [TEST_BUG][macosx] apparent regression: javax/swing/JColorChooser/Test7194184.java

2016-09-06 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 9/6/2016 9:12 AM, Avik Niyogi wrote: Hi All, Kindly review the fix for JDK9. *Bug: https://bugs.openjdk.java.net/browse/JDK-8163274* *Webrev: http://cr.openjdk.java.net/~aniyogi/8163274/webrev.00/

[9] Review request for 8165485 Bad rendering of Swing UI controls with Motif L on HiDPI display

2016-09-06 Thread Alexandr Scherbatiy
Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8165485 webrev: http://cr.openjdk.java.net/~alexsch/8165485/webrev.00 The icons drawing is changed to use ovals and polygons for JRadioButton, JCheckBox, JComboBox, and JScrollBar. The screenshots [1],

Re: Review Request: JDK-8009477 :PageUp and PageDown keyboard buttons don't move slider indicator to next minor tick

2016-09-06 Thread Prem Balakrishnan
Hi Alexandr, Thank you for the feedback. I have updated patch as per review comments. http://cr.openjdk.java.net/~pkbalakr/8009477/webrev.01/ Regards, Prem From: Alexandr Scherbatiy Sent: Monday, September 05, 2016 3:50 PM To: Prem Balakrishnan; Sergey Bylokhov; Rajeev Chamyal;

8163274: [TEST_BUG][macosx] apparent regression: javax/swing/JColorChooser/Test7194184.java

2016-09-06 Thread Avik Niyogi
Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8163274 Webrev: http://cr.openjdk.java.net/~aniyogi/8163274/webrev.00/ Issue: This test