Re: 8163274: [TEST_BUG][macosx] apparent regression: javax/swing/JColorChooser/Test7194184.java

Looks good to me. Regards, Rajeev Chamyal From: Avik Niyogi Sent: 08 September 2016 11:00 To: Rajeev Chamyal Cc: Alexandr Scherbatiy; swing-dev@openjdk.java.net Subject: Re: 8163274: [TEST_BUG][macosx] apparent regression: javax/swing/JColorChooser/Test7194184.java A gentle

Re: 8163274: [TEST_BUG][macosx] apparent regression: javax/swing/JColorChooser/Test7194184.java

A gentle reminder, please review code changes as indicated in new webrev. With Regards, Avik Niyogi > On 07-Sep-2016, at 9:50 pm, Alexandr Scherbatiy > wrote: > > The fix looks good to me. > > Thanks, > Alexandr. > > On 9/7/2016 9:02 AM, Avik Niyogi wrote: >>

Re: [9] Review request for 8165485 Bad rendering of Swing UI controls with Motif L on HiDPI display

Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8165485/webrev.01 Round line end decoration is used to draw combo box and scroll bar icons. [1], [2], and [3] screenshots show difference between icons drawing before and after the fix for scales 1x, 2x, and 4x.

Re: [9] Review request for 8165485 Bad rendering of Swing UI controls with Motif L on HiDPI display

drawPolyline does not seem to be an option here because of the different colours. Filling custom shapes may be overkill. Round looks to me to be the best of these three. -phil. On 9/7/2016 9:19 AM, Alexandr Scherbatiy wrote: On 9/6/2016 6:10 PM, Sergey Bylokhov wrote: It seems that there

Re: 8163274: [TEST_BUG][macosx] apparent regression: javax/swing/JColorChooser/Test7194184.java

The fix looks good to me. Thanks, Alexandr. On 9/7/2016 9:02 AM, Avik Niyogi wrote: Hi All, Kindly review the updated fix for JDK9 with new inputs incorporated. *Webrev: http://cr.openjdk.java.net/~aniyogi/8163274/webrev.01/ * With

Re: [9] Review request for 8165485 Bad rendering of Swing UI controls with Motif L on HiDPI display

On 9/6/2016 6:10 PM, Sergey Bylokhov wrote: It seems that there are some small artifacts on some of the components, please take a look to the corners of the selected checkbox. In 1x the corners have correct edges but in x2,x4 there are some missing pixels. Similar issue is in the text

[9] Review request for 8165594 Bad rendering of Swing UI controls with Windows Classic L on HiDPI display

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8165594 webrev: http://cr.openjdk.java.net/~alexsch/8165594/webrev.00 The icons drawing is changed to use ovals and polygons for JRadioButton, JCheckBox, JComboBox, and JScrollBar. The screenshots [1],