Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

2016-09-12 Thread Semyon Sadetsky
On 9/12/2016 9:48 PM, Alexandr Scherbatiy wrote: On 9/12/2016 7:52 PM, Semyon Sadetsky wrote: On 9/12/2016 6:50 PM, Alexandr Scherbatiy wrote: On 9/12/2016 6:42 PM, Semyon Sadetsky wrote: GTKPainter does not implement a lot of methods which can be accessed by public API. Could you, please,

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

2016-09-12 Thread Alexandr Scherbatiy
On 9/12/2016 7:52 PM, Semyon Sadetsky wrote: On 9/12/2016 6:50 PM, Alexandr Scherbatiy wrote: On 9/12/2016 6:42 PM, Semyon Sadetsky wrote: GTKPainter does not implement a lot of methods which can be accessed by public API. Could you, please, explain, why this specific method is more

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

2016-09-12 Thread Semyon Sadetsky
On 9/12/2016 6:50 PM, Alexandr Scherbatiy wrote: On 9/12/2016 6:42 PM, Semyon Sadetsky wrote: GTKPainter does not implement a lot of methods which can be accessed by public API. Could you, please, explain, why this specific method is more important than, for example,

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

2016-09-12 Thread Alexandr Scherbatiy
On 9/12/2016 6:42 PM, Semyon Sadetsky wrote: GTKPainter does not implement a lot of methods which can be accessed by public API. Could you, please, explain, why this specific method is more important than, for example, paintToolBarContentBackground() or paintToggleButtonBorder(), or all other

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

2016-09-12 Thread Semyon Sadetsky
GTKPainter does not implement a lot of methods which can be accessed by public API. Could you, please, explain, why this specific method is more important than, for example, paintToolBarContentBackground() or paintToggleButtonBorder(), or all other unimplemented? In general, how do you

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

2016-09-12 Thread Alexandr Scherbatiy
The paintTabbedPaneTabBorder() without orientation should be implemented as well because it can be accessed by public API. Thanks, Alexandr. On 6/3/2016 10:54 PM, Semyon Sadetsky wrote: On 6/3/2016 10:34 PM, Sergey Bylokhov wrote: On 03.06.16 22:21, Semyon Sadetsky wrote: What reason? Why

Re: [9] Review request for JDK-8150176 [hidpi] wrong resolution variant of multi-res. image is used for TrayIcon

2016-09-12 Thread Alexandr Scherbatiy
On 9/9/2016 3:06 PM, Rajeev Chamyal wrote: Hello Alexandr, Please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8150176/webrev.02/ WTrayIconPeer.java +gr.drawImage(image, 0, 0, (autosize ? w :

Re: [PATCH] JDK-7169915 : Swing Table Layout bad repaint of the row [REGRESSION] JDK-8133864 : Wrong display, when the document I18n properties is true.

2016-09-12 Thread Semyon Sadetsky
Hello, The JDK-8133864 seems has no a regression. I found that your test works well after it (with corrections I described in JIRA for the table frame). If TableView layout is still an incorrect for you, please, attach a test that fails before and passes after your fix. Test is required for

Re: [9] Review request for 8156217 Selected text is shifted on HiDPI display

2016-09-12 Thread Alexandr Scherbatiy
Hello, Could you review the updated fix: all changes: http://cr.openjdk.java.net/~alexsch/8156217/webrev.07/all public API changes: http://cr.openjdk.java.net/~alexsch/8156217/webrev.07/public-api - @since 9 tag is added to new methods. Thanks, Alexandr. On 9/10/2016 2:36 AM,