Re: [9] Review request for 8165234 Provide a way to not close toggle menu items on mouse click on component level

2016-09-14 Thread Sergey Bylokhov
Hi, Alexandr. I think we should double check how we operate on this property in case of custom L Our code relies that this property is set to "true" by default. And if the custom look, which knows nothing about it will be in use, then the code in SwingUtilities2 returns false. Is it expected?

Re: [9] Review request for JDK-8150176 [hidpi] wrong resolution variant of multi-res. image is used for TrayIcon

2016-09-14 Thread Sergey Bylokhov
Is "MultiResolutionTrayIconTest.html" should be removed? On 14.09.16 17:44, Alexandr Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 9/14/2016 12:01 PM, Rajeev Chamyal wrote: Hello Alexandr, Thanks for the review. Please review the webrev updated as per review comments.

Re: [9] Review request for 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups.

2016-09-14 Thread Alexandr Scherbatiy
On 9/14/2016 6:41 PM, Alexandr Scherbatiy wrote: On 9/14/2016 1:48 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8154043 webrev: http://cr.openjdk.java.net/~ssadetsky/8154043/webrev/ The new RadioButton group focus traversal

Re: javax.swing.text.html.parser.NPrintWriter

2016-09-14 Thread Alexandr Scherbatiy
On 9/14/2016 7:35 PM, Sergey Bylokhov wrote: I think that NPrintWriter is not public and is not used in jdk. May be it it has sense just to remove it? Thanks, Alexandr. On 14.09.16 19:29, Alexandr Scherbatiy wrote: Hello Manuel, Thank you for the feedback. I have filled an issue on

Re: [9] Review request for 8165594 Bad rendering of Swing UI controls with Windows Classic L on HiDPI display

2016-09-14 Thread Semyon Sadetsky
Hi Alexander, When I press the arrow button (for example in the "111" combo) several times I can see artifacts. They are well seen in scale x4. --Semyon On 9/14/2016 5:39 PM, Alexandr Scherbatiy wrote: Hello, Could you review the updated fix:

Re: javax.swing.text.html.parser.NPrintWriter

2016-09-14 Thread Sergey Bylokhov
I think that NPrintWriter is not public and is not used in jdk. On 14.09.16 19:29, Alexandr Scherbatiy wrote: Hello Manuel, Thank you for the feedback. I have filled an issue on it [1]: JDK-8166050 partialArray is not created in javax.swing.text.html.parser.NPrintWriter.println(...) method

Re: javax.swing.text.html.parser.NPrintWriter

2016-09-14 Thread Alexandr Scherbatiy
Hello Manuel, Thank you for the feedback. I have filled an issue on it [1]: JDK-8166050 partialArray is not created in javax.swing.text.html.parser.NPrintWriter.println(...) method Do you have any particular test which runs into this issue? [1]

Re: [9] Review request for 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups.

2016-09-14 Thread Alexandr Scherbatiy
On 9/14/2016 1:48 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8154043 webrev: http://cr.openjdk.java.net/~ssadetsky/8154043/webrev/ The new RadioButton group focus traversal algorithm introduced by JDK-8033699 doesn't take into

javax.swing.text.html.parser.NPrintWriter

2016-09-14 Thread Manuel Kassens
Hi, i found an error in

Re: [9] Review request for JDK-8150176 [hidpi] wrong resolution variant of multi-res. image is used for TrayIcon

2016-09-14 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 9/14/2016 12:01 PM, Rajeev Chamyal wrote: Hello Alexandr, Thanks for the review. Please review the webrev updated as per review comments. http://cr.openjdk.java.net/~rchamyal/8150176/webrev.03/

Re: [9] Review request for 8165594 Bad rendering of Swing UI controls with Windows Classic L on HiDPI display

2016-09-14 Thread Alexandr Scherbatiy
Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8165594/webrev.01 - HiDPI icons are only drawn for scaled graphics. The screenshots [1], [2], and [3] show difference between icons drawing before and after the fix for scales 1x, 2x, and 4x. [1]

[9] Review request for 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups.

2016-09-14 Thread Semyon Sadetsky
Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8154043 webrev: http://cr.openjdk.java.net/~ssadetsky/8154043/webrev/ The new RadioButton group focus traversal algorithm introduced by JDK-8033699 doesn't take into account that group of radio buttons can be

[9] fix for JDK-8134612 :clipboard.getData(dataFlavor) can throw UnsupportedFlavorException for registered data flavor

2016-09-14 Thread Ajit Ghaisas
Hi, Bug : https://bugs.openjdk.java.net/browse/JDK-8134612 Issue : In this test, exportToClipboard() does not export anything to the clipboard due to incorrect text passed to TransferHandler. Obviously, when we do clipboard.getData() - it throws UnsupportedFlavorException. This is the

Re: [9] Review request for JDK-8150176 [hidpi] wrong resolution variant of multi-res. image is used for TrayIcon

2016-09-14 Thread Rajeev Chamyal
Hello Alexandr, Thanks for the review. Please review the webrev updated as per review comments. http://cr.openjdk.java.net/~rchamyal/8150176/webrev.03/ Regards, Rajeev Chamyal From: Alexandr Scherbatiy Sent: 12 September 2016 20:07 To: Rajeev Chamyal; swing-dev@openjdk.java.net;