Re: [9] Review request for 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups.

2016-09-15 Thread Alexander Scherbatiy
On 15/09/16 15:03, Semyon Sadetsky wrote: On 15.09.2016 12:49, Alexandr Scherbatiy wrote: On 9/15/2016 11:47 AM, Semyon Sadetsky wrote: On 14.09.2016 21:00, Alexandr Scherbatiy wrote: On 9/14/2016 6:41 PM, Alexandr Scherbatiy wrote: On 9/14/2016 1:48 PM, Semyon Sadetsky wrote: Hello, Plea

Re: [9] Review request for 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups.

2016-09-15 Thread Semyon Sadetsky
On 15.09.2016 12:49, Alexandr Scherbatiy wrote: On 9/15/2016 11:47 AM, Semyon Sadetsky wrote: On 14.09.2016 21:00, Alexandr Scherbatiy wrote: On 9/14/2016 6:41 PM, Alexandr Scherbatiy wrote: On 9/14/2016 1:48 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.

Re: [9] Review request for 8163124 Add floating point API support to javax.swing.text.Caret

2016-09-15 Thread Semyon Sadetsky
Hi Alexander, Could you run the next test (with x8 scale, for example): public class New2dApiTest { public static void main(String[] args) { JTextArea jTextArea2d = new JTextArea("jksxbqhbxniiiaiiaawww") { @Override protected void paintComponent(Graphics g) {

Re: [9] Review request for JDK-8150176 [hidpi] wrong resolution variant of multi-res. image is used for TrayIcon

2016-09-15 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 9/15/2016 1:01 PM, Sergey Bylokhov wrote: +1 On 15.09.16 9:24, Rajeev Chamyal wrote: Hello Sergey, I have removed the html file. http://cr.openjdk.java.net/~rchamyal/8150176/webrev.03/ Regards, Rajeev Chamyal -Original Message- From: S

Re: Review Request for 8163261: regression on Linux: java/awt/LightweightDispatcher/LWDispatcherMemoryLeakTest.java

2016-09-15 Thread Sergey Bylokhov
+1 On 06.09.16 18:33, Alexandr Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 9/6/2016 6:21 PM, Ambarish Rapte wrote: Hi Alex, 1. There will be only one key value pair entry in the /cacheMap/. The CachedPainter.paint0() method uses getClass() as a key for the cac

Re: [9] Review request for JDK-8150176 [hidpi] wrong resolution variant of multi-res. image is used for TrayIcon

2016-09-15 Thread Sergey Bylokhov
+1 On 15.09.16 9:24, Rajeev Chamyal wrote: Hello Sergey, I have removed the html file. http://cr.openjdk.java.net/~rchamyal/8150176/webrev.03/ Regards, Rajeev Chamyal -Original Message- From: Sergey Bylokhov Sent: 14 September 2016 23:39 To: Alexandr Scherbatiy; Rajeev Chamyal; swing-

Re: [9] Review request for 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups.

2016-09-15 Thread Alexandr Scherbatiy
On 9/15/2016 11:47 AM, Semyon Sadetsky wrote: On 14.09.2016 21:00, Alexandr Scherbatiy wrote: On 9/14/2016 6:41 PM, Alexandr Scherbatiy wrote: On 9/14/2016 1:48 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8154043 webrev: http:/

Re: [9] Review request for 8165234 Provide a way to not close toggle menu items on mouse click on component level

2016-09-15 Thread Alexandr Scherbatiy
Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8165234/webrev.02 The closeOnMouseClick property is renamed to doNotCloseOnMouseClick with the default false value. The client property is queried in the first place. If it is not set the L&F property val

Re: [9] Review request for 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups.

2016-09-15 Thread Semyon Sadetsky
On 14.09.2016 21:00, Alexandr Scherbatiy wrote: On 9/14/2016 6:41 PM, Alexandr Scherbatiy wrote: On 9/14/2016 1:48 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8154043 webrev: http://cr.openjdk.java.net/~ssadetsky/8154043/webre