Re: RFR: PIT Bug 8167988 : java.nio.file.InvalidPathException if click button in JFileChooser demo of SwingSet2

2016-10-24 Thread Semyon Sadetsky
It seems the fix should be: === --- src/java.desktop/share/classes/sun/awt/shell/ShellFolder.java +++ src/java.desktop/share/classes/sun/awt/shell/ShellFolder.java @@ -244,10 +244,10 @@ * @exception FileNotFoundException if fil

Re: [9] Review request for 8075904: The regression-swing case failed as Ctrl-F4 can't work with the special options"-client -Dswing.defaultlaf=javax.swing.plaf.nimbus.NimbusLookAndFeel"

2016-10-24 Thread Sergey Bylokhov
Looks fine. On 21.10.16 19:22, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8075904 webrev: http://cr.openjdk.java.net/~ssadetsky/8075904/webrev.00/ Missed key-bindings are added for DesktopPane in Nimbus L&F. --Semyon -- Best r

Re: [9] Review request for 8075918: The regression-swing case failed as the long Tab titles are not clipped with dots at the end with the special options"-client -Dswing.defaultlaf=javax.s

2016-10-24 Thread Sergey Bylokhov
Probably this clipping should be done in the 633 paintText(ss, g, tabPlacement, font, metrics, 634 tabIndex, clippedTitle, textRect, isSelected); ? It seems that currently this method contradicts its specification and skips the w/h of the passed bounds(in this ca

Re: RFR: PIT Bug 8167988 : java.nio.file.InvalidPathException if click button in JFileChooser demo of SwingSet2

2016-10-24 Thread Sergey Bylokhov
+1 On 25.10.16 1:26, Phil Race wrote: SQE reports some 35 tests fail as a result of this bug. I am backing out the change that caused it from our PIT and need a reviewer. SQE will verify this before I push. Bug: https://bugs.openjdk.java.net/browse/JDK-8167988 Fix : hg diff src/java.desktop/s

RFR: PIT Bug 8167988 : java.nio.file.InvalidPathException if click button in JFileChooser demo of SwingSet2

2016-10-24 Thread Phil Race
SQE reports some 35 tests fail as a result of this bug. I am backing out the change that caused it from our PIT and need a reviewer. SQE will verify this before I push. Bug: https://bugs.openjdk.java.net/browse/JDK-8167988 Fix : hg diff src/java.desktop/share/classes/sun/awt/shell/ShellFolder.j

Re: [9] Review request for 8162350 RepaintManager shifts repainted region when the floating point UI scale is used

2016-10-24 Thread Alexandr Scherbatiy
Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8162350/webrev.01 - JScrollPane copy area functionality is disabled for floating point scale - VolatileImage buffer size is recalculates using transform translate Using floating point scale leads that d

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-24 Thread Erik Joelsson
The last change looks good and simple to me. /Erik On 2016-10-21 06:55, Pete Brunet wrote: Please see the latest update http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.02/ The fix now is to simply remove the copy of the AccessBridgeCalls.c file into the JDK. AccessBridgeCalls.c is th