Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

2016-12-22 Thread Mandy Chung
> On Dec 22, 2016, at 1:33 AM, Semyon Sadetsky > wrote: > > > > On 20.12.2016 19:41, Mandy Chung wrote: >> >>> On Dec 20, 2016, at 8:24 AM, Sergey Bylokhov >> > wrote: >>> >> If this private data can be loaded to the UIDefaults or to other class >

Re: [9] RFR: JDK-8170349: The printed content is beyond the borders.

2016-12-22 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 12/22/2016 2:35 PM, Prasanta Sadhukhan wrote: Modified webrev to use null instead of "" to clear the property. Also, removed the casting and just use Object. http://cr.openjdk.java.net/~psadhukhan/8170349/webrev.03/ Regards Prasanta On 1

Re: [9] RFR: JDK-8170349: The printed content is beyond the borders.

2016-12-22 Thread Prasanta Sadhukhan
Modified webrev to use null instead of "" to clear the property. Also, removed the casting and just use Object. http://cr.openjdk.java.net/~psadhukhan/8170349/webrev.03/ Regards Prasanta On 12/22/2016 1:18 PM, Prasanta Sadhukhan wrote: Used put/getClientProperty instead of UIManager.put/get.

Re: [9] RFR: JDK-8170349: The printed content is beyond the borders.

2016-12-22 Thread Prasanta Sadhukhan
Used put/getClientProperty instead of UIManager.put/get. Please find modified webrev: http://cr.openjdk.java.net/~psadhukhan/8170349/webrev.02/ Regards Prasanta On 12/21/2016 5:06 PM, Prasanta Sadhukhan wrote: Hi Alex, Further to our discussion where you suggested not to modify table setBou

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

2016-12-22 Thread Semyon Sadetsky
On 20.12.2016 19:41, Mandy Chung wrote: On Dec 20, 2016, at 8:24 AM, Sergey Bylokhov mailto:sergey.bylok...@oracle.com>> wrote: If this private data can be loaded to the UIDefaults or to other class then it will be read anyway. Are the Swing/AWT properties files content really secret? My