Re: [9] Review request for 8179027: JComboBox too small under Windows LAF

2017-04-26 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 4/25/2017 6:55 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8179027 webrev: http://cr.openjdk.java.net/~ssadetsky/8179027/webrev.00/ This a regression introduced by JDK-6490753. The

Re: [9] Review request for 8179027: JComboBox too small under Windows LAF

2017-04-26 Thread Phil Race
OK. +1. No point in adding constants right now. I had thought the change that introduced this was not related to hidpi but it was not .. and it was a bit larger than I'd have expected this late in the release. -phil. On 04/26/2017 08:41 AM, Semyon Sadetsky wrote: I don't see any issues with s

Re: [9] Review request for 8179027: JComboBox too small under Windows LAF

2017-04-26 Thread Semyon Sadetsky
I don't see any issues with scaling. Component size calculation shouldn't depend on scaling (it produces the same size at any scale). The only issue I found with 125% and 150% scale is the drop-down popup location which is shifted by several pixels from the correct position. But this issue was

Re: [9] Review request for 8140237: [TEST_BUG]Test javax/swing/plaf/nimbus/8041642/bug8041642.java fails for OEL 7

2017-04-26 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 4/21/2017 8:29 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8140237 webrev: http://cr.openjdk.java.net/~ssadetsky/8140237/webrev.00/ Delay was fixed to improve test stability on OE