Re: Nimbus class extending.

2017-05-09 Thread Alexandr Scherbatiy
On 5/5/2017 2:08 PM, Ashutosh Pandey wrote: Hello, I was wondering if someone can offer an advice on how can I modify Nimbus L& F classes. We have used Nimbus L&F in a sizable desktop product. But lately our customers have been reporting class cast exceptions which upon some digging appear

Re: [9] Review Request: 8179596 Update java.desktop to be HTML-5 friendly

2017-05-09 Thread Alex Menkov
Okay, Then +1 to Phil's approval --alex On 05/05/2017 12:37, Sergey Bylokhov wrote: Hi, Alexey. Yes it is possible to add to this changes, but actually tag is not used in JavaSound docs. The last one were removed a few years ago. The tag is used in assumption that it affect the text till

Nimbus class extending.

2017-05-09 Thread Ashutosh Pandey
Hello, I was wondering if someone can offer an advice on how can I modify Nimbus L& F classes. We have used Nimbus L&F in a sizable desktop product. But lately our customers have been reporting class cast exceptions which upon some digging appears to be threading issues. I am looki

Re: [9] Review Request: 8179596 Update java.desktop to be HTML-5 friendly

2017-05-09 Thread Jonathan Gibbons
Sergey, This is not a comment on the content of the review; it is a minor comment on your interpretation of . is a block-level tag that is implicitly terminated by any of many block-level tags. For the full list, see the W3C definition of the p element in HTML 5: https://www.w3.org/TR/html

Re: [9] Review Request: 8179596 Update java.desktop to be HTML-5 friendly

2017-05-09 Thread Alex Menkov
Overall looks good. One minor point - there are several places when you replace with without end . Usually absent doesn't cause any problem, but it would be better to have end tags for all elements. I see this in src/java.desktop/share/classes/javax/sound/midi/MidiMessage.java src/java.desk

Re: [9] JDK-8169897: [PIT] javax/swing/plaf/basic/BasicGraphicsUtils/8132119/bug8132119.java fails

2017-05-09 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 5/5/2017 7:56 AM, Prasanta Sadhukhan wrote: I have updated the fix to calculate "xx" (the x coordinate along which background changes willbe calculated from top to bottom of bufferedimage) to point to centre of "O" so that background change can c