Re: [9] JDK-8165213: [TESTBUG] [PIT] consistent failure of a new regtest for 8163193

2017-06-06 Thread Shashidhara Veerabhadraiah
I checked with isEventDispatchThread() java api on the program and found that it is not running on EDT but running on the initial thread!! Is it really required to run the frame paint on the EDT as it is not a responsive GUI(non-event based) but an automatic test case to capture the image onto a

Re: [9] Review Request: 8180326 Update the tables in java.desktop to be HTML-5 friendly

2017-06-06 Thread Alexander Zvegintsev
Hi Sergey, Why do we omitting closing th tag? e.g. + * Metal's system color mapping + * + * + * Key + * Value + * I know that HTML parsers are usually forgiving such things. But sometimes it may make thing worse: https://stackoverflow.com/questions/7125354/what-are-the-actual-problems-of

Re: [9] JDK-8165213: [TESTBUG] [PIT] consistent failure of a new regtest for 8163193

2017-06-06 Thread Prasanta Sadhukhan
Looks better. One more thing, out of these lines, only frame.paint() needs to be in EDT as it is a swing component but in your code, all code are running under EDT which is not needed. 113 114 // Capture the frame to an buffered image file as an ARGB file 115 bi = new BufferedImage(300 * (int)(

Re: [9] JDK-8165213: [TESTBUG] [PIT] consistent failure of a new regtest for 8163193

2017-06-06 Thread Shashidhara Veerabhadraiah
Hi, I have updated the Webrev with fixes for the comments @ http://cr.openjdk.java.net/~pkbalakr/shashi/8165213/webrev_02/. Prasanth, I am not aware of the JBS id where this issue is going to be fixed. Thanks and regards, Shashi -Original Message- From: Prasanta Sadhukhan Sent: Tuesday

Re: [10] RFR: JDK-8075918:The regression-swing case failed as the long Tab titles are not clipped with dots at the end with NimbusLookAndFeel

2017-06-06 Thread Prasanta Sadhukhan
Please find the modified webrev incorporating your review comment http://cr.openjdk.java.net/~psadhukhan/8075918/webrev.04/ Regards Prasanta On 6/2/2017 12:33 AM, Sergey Bylokhov wrote: - There is a problem in your algorithm which merges the old and new clips. The getClipBounds() returns a r

Re: [9] JDK-8165213: [TESTBUG] [PIT] consistent failure of a new regtest for 8163193

2017-06-06 Thread Prasanta Sadhukhan
Do you know the JBS bugid of Robot's issue that is being resolved? I guess you need to call g2d.dispose() in printToBufferedImage() and can replace the wild card imports into specific imports. Also, take care of 80characters per line. Regards Prasa On 6/6/2017 12:04 PM, Shashidhara Veerabhadra