Re: [10] RFR JDK-8183529: FilleChooser in "Detail view" does not change the Language of the column headings

2017-07-10 Thread Prasanta Sadhukhan
On 7/11/2017 2:28 AM, Semyon Sadetsky wrote: On 07/10/2017 01:48 PM, Sergey Bylokhov wrote: So just to confirm that in the case when the "JComponent.setDefaultLocale(English)" will be called on non-English system the whole chooser will use English for all parts. I think so, keys should be

[10] Review Request: 8134256 copy/paste duplicated tests in some condition statements

2017-07-10 Thread Sergey Bylokhov
Hello, Please review the fix for jdk10. Two typos were fixed. Actually the tests are more complicated than the fix itself. Bug: https://bugs.openjdk.java.net/browse/JDK-8134256 Webrev can be found at: http://cr.openjdk.java.net/~serb/8134256/webrev.03

Re: [10] RFR JDK-8183529: FilleChooser in "Detail view" does not change the Language of the column headings

2017-07-10 Thread Semyon Sadetsky
On 07/10/2017 01:48 PM, Sergey Bylokhov wrote: So just to confirm that in the case when the "JComponent.setDefaultLocale(English)" will be called on non-English system the whole chooser will use English for all parts. I think so, keys should be used to get localized strings from the

Re: [10] RFR JDK-8183529: FilleChooser in "Detail view" does not change the Language of the column headings

2017-07-10 Thread Sergey Bylokhov
So just to confirm that in the case when the "JComponent.setDefaultLocale(English)" will be called on non-English system the whole chooser will use English for all parts. - semyon.sadet...@oracle.com wrote: > It seem this question was already discussed. Now in the fix the column

Re: [10] RFR JDK-8183529: FilleChooser in "Detail view" does not change the Language of the column headings

2017-07-10 Thread Semyon Sadetsky
It seem this question was already discussed. Now in the fix the column numbers are used instead of the titles. --Semyon On 07/10/2017 12:36 PM, Sergey Bylokhov wrote: Small question about current approach: will it be affected by the "JComponent.setDefaultLocale(someLocale)"? where some

Re: [10] RFR JDK-8183529: FilleChooser in "Detail view" does not change the Language of the column headings

2017-07-10 Thread Sergey Bylokhov
Small question about current approach: will it be affected by the "JComponent.setDefaultLocale(someLocale)"? where some locale is English on non-English system. - prasanta.sadhuk...@oracle.com wrote: > > > > On 7/10/2017 8:37 PM, Semyon Sadetsky wrote: > On 07/10/2017 08:01 AM,

Re: [10] RFR JDK-8183529: FilleChooser in "Detail view" does not change the Language of the column headings

2017-07-10 Thread Prasanta Sadhukhan
On 7/10/2017 8:37 PM, Semyon Sadetsky wrote: On 07/10/2017 08:01 AM, Prasanta Sadhukhan wrote: On 7/10/2017 8:29 PM, Semyon Sadetsky wrote: Hi Prasanta, Please, add static modifier to those java constants. It causes "NoSuchFieldError" if we access static field defined in java from

Re: [10] RFR JDK-8183529: FilleChooser in "Detail view" does not change the Language of the column headings

2017-07-10 Thread Semyon Sadetsky
On 07/10/2017 08:01 AM, Prasanta Sadhukhan wrote: On 7/10/2017 8:29 PM, Semyon Sadetsky wrote: Hi Prasanta, Please, add static modifier to those java constants. It causes "NoSuchFieldError" if we access static field defined in java from jni. I did not get this. It is impossible to read

Re: [10] RFR JDK-8183529: FilleChooser in "Detail view" does not change the Language of the column headings

2017-07-10 Thread Prasanta Sadhukhan
On 7/10/2017 8:29 PM, Semyon Sadetsky wrote: Hi Prasanta, Please, add static modifier to those java constants. It causes "NoSuchFieldError" if we access static field defined in java from jni. Also, in ShellFolder2.cpp, could you move the initialization lines from _doGetColumnInfo() to

Re: [10] RFR JDK-8183529: FilleChooser in "Detail view" does not change the Language of the column headings

2017-07-10 Thread Semyon Sadetsky
Hi Prasanta, Please, add static modifier to those java constants. Also, in ShellFolder2.cpp, could you move the initialization lines from _doGetColumnInfo() to _initIDs()? --Semyon On 07/07/2017 10:49 PM, Prasanta Sadhukhan wrote: On 7/8/2017 2:22 AM, Semyon Sadetsky wrote: Why you