Re: [OpenJDK 2D-Dev] [10] Review Request: 8187399 Different problems in the javadoc's links in java.desktop package

2017-09-15 Thread Sergey Bylokhov
That's of course a stylistic issue, but I think that the keywords(not necessary a java) look better when they are highlighted. Depending from the style it can look like this: http://cr.openjdk.java.net/~serb/8187399/img.png Here is an updated webrev:

Re: [OpenJDK 2D-Dev] [10] Review Request: 8187399 Different problems in the javadoc's links in java.desktop package

2017-09-15 Thread Alan Snyder
It’s also not English, which not using @code would make it look like... > On Sep 15, 2017, at 12:34 PM, Phil Race wrote: > > 771 * @implNote Please note that for Mac OS, notifications > 772 * are only sent if the Java app is a bundled application, > 773

Re: [OpenJDK 2D-Dev] [10] Review Request: 8187399 Different problems in the javadoc's links in java.desktop package

2017-09-15 Thread Phil Race
771 * @implNote Please note that for Mac OS, notifications 772 * are only sent if the Java app is a bundled application, 773 * with a {@code CFBundleDocumentTypes} array present in its 774 * Info.plist. Should we be using {@code ..} for CFBundleDocumentTypes. It is not Java

Re: [10] JDK-8004029: [macosx] The long Tab titles are not clipped with dots at the end.

2017-09-15 Thread Prasanta Sadhukhan
+1 Regards Prasanta On 9/15/2017 3:16 PM, Shashidhara Veerabhadraiah wrote: Hi Prasanta, Please find the updated Webrev @ http://cr.openjdk.java.net/~sveerabhadra/8004029/webrev.05/ Thanks and regards, Shashi *From:*Prasanta

Re: [10] JDK-8004029: [macosx] The long Tab titles are not clipped with dots at the end.

2017-09-15 Thread Shashidhara Veerabhadraiah
Hi Prasanta, Please find the updated Webrev @ http://cr.openjdk.java.net/~sveerabhadra/8004029/webrev.05/   Thanks and regards, Shashi   From: Prasanta Sadhukhan Sent: Friday, September 15, 2017 3:11 PM To: Shashidhara Veerabhadraiah ;

Re: [10] JDK-8004029: [macosx] The long Tab titles are not clipped with dots at the end.

2017-09-15 Thread Prasanta Sadhukhan
looks better. but, disposeUI() do not throw any exception so no need to catch in try { 122 if(test != null) { 123 test.disposeUI(); 124 } 125 } catch (Exception ex) { 126 throw new RuntimeException("Exception while disposing UI"); 127 } Regards Prasanta On 9/15/2017 2:57 PM,

Re: [10] JDK-8004029: [macosx] The long Tab titles are not clipped with dots at the end.

2017-09-15 Thread Shashidhara Veerabhadraiah
Hi, Here is the updated webrev. Removed unnecessary try catch blocks!!   http://cr.openjdk.java.net/~sveerabhadra/8004029/webrev.04/   Thanks and regards, Shashi   From: Prasanta Sadhukhan Sent: Thursday, September 14, 2017 4:26 PM To: Shashidhara Veerabhadraiah