Re: [10] RFR JDK-8178025:HiDPI with non-integer scale factor - SPANs in HTML are rendered overlapping each other

2017-11-14 Thread Prasanta Sadhukhan
Hi Sergey, Ok. Updated test to move to 1st screen and then to 2nd screen http://cr.openjdk.java.net/~psadhukhan/8178025/webrev.09/ Regards Prasanta On 11/15/2017 1:38 AM, Sergey Bylokhov wrote: Hi, Prasanta. I checked the test and it fails on my environment, and the reason is that I have the m

Re: RFR: 8157338 sanity/client/SwingSet/src/ButtonDemoScreenshotTest.java is unstable

2017-11-14 Thread Sergey Bylokhov
Looks fine. On 14/11/2017 14:52, Alexandre (Shura) Iline wrote: On Nov 14, 2017, at 2:03 PM, Sergey Bylokhov wrote: Hi, Shura. This test was added to the open/test/jdk/ProblemList.txt: # jdk_swing sanity/client/SwingSet/src/ButtonDemoScreenshotTest.java8157338 generic-all If the b

Re: RFR: 8157338 sanity/client/SwingSet/src/ButtonDemoScreenshotTest.java is unstable

2017-11-14 Thread Alexandre (Shura) Iline
> On Nov 14, 2017, at 2:03 PM, Sergey Bylokhov > wrote: > > Hi, Shura. > This test was added to the open/test/jdk/ProblemList.txt: > # jdk_swing > sanity/client/SwingSet/src/ButtonDemoScreenshotTest.java8157338 > generic-all > > If the bug is fixed then this record can be removed.

Re: [10][JDK-8075084] JOptionPane.showMessageDialog causes JScrollBar to move

2017-11-14 Thread Sergey Bylokhov
Hi, Krishna. Last time in the discussion we had a question why it is not possible to reproduce the bug using JFrame and focus manipulation in the same way as "JOptionPane.showMessageDialog" works. Did you check why it works in one case and does not work in another? On 12/11/2017 22:41, Krishn

Re: RFR: 8157338 sanity/client/SwingSet/src/ButtonDemoScreenshotTest.java is unstable

2017-11-14 Thread Sergey Bylokhov
Hi, Shura. This test was added to the open/test/jdk/ProblemList.txt: # jdk_swing sanity/client/SwingSet/src/ButtonDemoScreenshotTest.java8157338 generic-all If the bug is fixed then this record can be removed. On 14/11/2017 11:03, Alexandre (Shura) Iline wrote: Hi, Please take a loo

Re: [10][JDK-8178430] JMenu in GridBagLayout flickers when label text shows "..." and is updated

2017-11-14 Thread Sergey Bylokhov
Hi, Krishna. Small comments: I think that this code "(JMenu)menuItem).isTopLevelMenu() == true" can be simplified to (JMenu)menuItem).isTopLevelMenu(). In the test you create and dispose JFrame and other components outside of EDT thread. I suggest to use invokeAndWait() which will work synchron

Re: [10] RFR JDK-8178025:HiDPI with non-integer scale factor - SPANs in HTML are rendered overlapping each other

2017-11-14 Thread Sergey Bylokhov
Hi, Prasanta. I checked the test and it fails on my environment, and the reason is that I have the main screen on the right and the second screen on the left, which means that the test moves the window outside of any screens. But it should move the window to one screen and then to another scree

RFR: 8157338 sanity/client/SwingSet/src/ButtonDemoScreenshotTest.java is unstable

2017-11-14 Thread Alexandre (Shura) Iline
Hi, Please take a look on this fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8157338 I have changed the code to _wait_ for the image change and I have also replaced some of the homemade code with proper Jemmy calls. Webrev: http://cr.openjdk.java.net/~shurailine/8157338/webrev.00/ Thank

Re: [10] Review Request: JDK-8190861: [TESTBUG] javax/swing/JWindow/ShapedAndTranslucentWindows/PerPixelTranslucentSwing.java is wrong

2017-11-14 Thread Prasanta Sadhukhan
+1 Regards Prasanta On 11/7/2017 10:24 PM, Pankaj Bansal wrote: Hi, Please review the fix for JDK 10. Bug: https://bugs.openjdk.java.net/browse/JDK-8190861 Webrev: http://cr.openjdk.java.net/~pbansal/8190861/webrev.00/ Issue: T