Re: JDK-8190348: [TESTBUG] Test javax/swing/JWindow/ShapedAndTranslucentWindows/PerPixelTranslucentCanvas.java fails

2017-11-16 Thread Prasanta Sadhukhan
+1 Regards Prasanta On 11/16/2017 4:28 PM, Pankaj Bansal wrote: Hi All, Please review the fix for JDK 10. Bug: https://bugs.openjdk.java.net/browse/JDK-8190348 Webrev: http://cr.openjdk.java.net/~pbansal/8190348/webrev.00/

Re: [10][JDK-8178430] JMenu in GridBagLayout flickers when label text shows "..." and is updated

2017-11-16 Thread Sergey Bylokhov
On 16/11/2017 09:17, Semyon Sadetsky wrote: This will not be a bug, if the application thinks that 2x2 or 200x200 are reasonable values for maximum/minimum/preferred sizes and will set it, then these values will be used. But according to the layout constraints there enough space for preferred

Re: [10] RFR JDK-8178025:HiDPI with non-integer scale factor - SPANs in HTML are rendered overlapping each other

2017-11-16 Thread Sergey Bylokhov
On 16/11/2017 09:05, Alan Snyder wrote: I think you are saying that the bound properties can be discovered using an inspector. I would call the inspector a tool. My point is that public property notifications are part of the API, and therefore should be documented in the javadoc, as has been

Re: [10] RFR JDK-8176072: READING attributes are not available on TSF

2017-11-16 Thread Semyon Sadetsky
Hi Sreeprakash, Shouldn't the AwtInputTextInfor::GetAttributeInfor be readdressed to m_pResultTextInfor as well? --Semyon On 11/16/2017 08:36 AM, Sreeprakash Sreedharan wrote: Hello All, Please review the following fix in JDK10. Bug : https://bugs.openjdk.java.net/browse/JDK-8176072

Re: [10][JDK-8178430] JMenu in GridBagLayout flickers when label text shows "..." and is updated

2017-11-16 Thread Semyon Sadetsky
Hi Sergey, On 11/15/2017 05:21 PM, Sergey Bylokhov wrote: On 15/11/2017 10:53, Semyon Sadetsky wrote: There are no such restrictions that getMinimumSize() must return exact value of getPrefferredSize(). It should return some reasonable value instead of null, which can be considered as 1x1 by

Re: [10][JDK-8178430] JMenu in GridBagLayout flickers when label text shows "..." and is updated

2017-11-16 Thread Semyon Sadetsky
Hi Krishna, On 11/16/2017 03:38 AM, Krishna Addepalli wrote: Hi Semyon, 1. I have tried in my Ubuntu 17.04 VM and was able to see the test case fail before fix, and passing after the fix. 2. Regarding the minimum size, it is not related to any layout - the test fails across any Layout - I

Re: [10] RFR JDK-8178025:HiDPI with non-integer scale factor - SPANs in HTML are rendered overlapping each other

2017-11-16 Thread Alan Snyder
I think you are saying that the bound properties can be discovered using an inspector. I would call the inspector a tool. My point is that public property notifications are part of the API, and therefore should be documented in the javadoc, as has been done (perhaps incorrectly) for Component.

[10] RFR JDK-8176072: READING attributes are not available on TSF

2017-11-16 Thread Sreeprakash Sreedharan
Hello All, Please review the following fix in JDK10. Bug : https://bugs.openjdk.java.net/browse/JDK-8176072 Webrev : http://cr.openjdk.java.net/~ssreedharan/8176072/jdk10/webrev.00/ The bug describes a scenario wherein reading (AttributedCharacterIterator.Attribute.READING)

Re: [10] RFR JDK-8178025:HiDPI with non-integer scale factor - SPANs in HTML are rendered overlapping each other

2017-11-16 Thread Semyon Sadetsky
On 11/15/2017 09:53 PM, Sergey Bylokhov wrote: That is a step in the right direction, but the idea that this public and supported property can only be discovered using a tool seems wrong to me. This is not a separate tool, it is a class which can operates on java beans. And the notification

Re: [10][JDK-8178430] JMenu in GridBagLayout flickers when label text shows "..." and is updated

2017-11-16 Thread Krishna Addepalli
Hi Semyon, 1. I have tried in my Ubuntu 17.04 VM and was able to see the test case fail before fix, and passing after the fix. 2. Regarding the minimum size, it is not related to any layout - the test fails across any Layout - I have verified this in debugging process. The only point is,

JDK-8190348: [TESTBUG] Test javax/swing/JWindow/ShapedAndTranslucentWindows/PerPixelTranslucentCanvas.java fails

2017-11-16 Thread Pankaj Bansal
Hi All, Please review the fix for JDK 10. Bug: https://bugs.openjdk.java.net/browse/JDK-8190348 Webrev: http://cr.openjdk.java.net/~pbansal/8190348/webrev.00/ Issue: The test fails with or without HiDPI with Exception. Failed. Execution failed: `main' threw exception: