Re: [11] RFR JDK-7190978:javax/swing/JComponent/7154030/bug7154030.java fails on windows, mac

2018-03-01 Thread Sergey Bylokhov
On 01/03/2018 06:02, Prasanta Sadhukhan wrote: Yes, I was also not convinced, that is why I tested for multiple iterations. It seems to me the webrev.00 is the better "fix" as I saw only 2-3 pixels differ which cause the exact match to fail. But,I am not sure why in linux, the bufferedimages ar

Re: [11] RFR JDK-8194943:Regression automated test 'open/test/jdk/javax/swing/JInternalFrame/8020708/bug8020708.java' fails

2018-03-01 Thread shashidhara . veerabhadraiah
Looks good to me Prasanta. On 01/03/18 11:35 PM, semyon.sadet...@oracle.com wrote: +1 --Semyon On 3/1/18 10:01 AM, Prasanta Sadhukhan wrote: Hi All, Please review a test fix for an issue whereby it is seen that close mnemonics for different locales was not working. The issue has nothing t

Re: [11] RFR JDK-8194943:Regression automated test 'open/test/jdk/javax/swing/JInternalFrame/8020708/bug8020708.java' fails

2018-03-01 Thread semyon . sadetsky
+1 --Semyon On 3/1/18 10:01 AM, Prasanta Sadhukhan wrote: Hi All, Please review a test fix for an issue whereby it is seen that close mnemonics for different locales was not working. The issue has nothing to do with menmonics but with the test using robot to press CTRL+SPACE to show system

[11] RFR JDK-8194943:Regression automated test 'open/test/jdk/javax/swing/JInternalFrame/8020708/bug8020708.java' fails

2018-03-01 Thread Prasanta Sadhukhan
Hi All, Please review a test fix for an issue whereby it is seen that close mnemonics for different locales was not working. The issue has nothing to do with menmonics but with the test using robot to press CTRL+SPACE to show system menu. However, it is found that CTRL+SPACE is a known hotkey c

Re: [11] RFR JDK-8198777: JList.getPreferredScrollableViewportSize(): fix mistake in doc for height calc

2018-03-01 Thread semyon . sadetsky
+1 --Semyon On 3/1/18 4:21 AM, Alexey Ivanov wrote: Hello Semyon, Thank you for your review. The updated version: http://cr.openjdk.java.net/~aivanov/8198777/webrev.1/ The case where the model is empty is covered in the paragraph above. No change is necessary there. Regards, Alexey On 0

Re: [11] RFR JDK-7190978:javax/swing/JComponent/7154030/bug7154030.java fails on windows, mac

2018-03-01 Thread Prasanta Sadhukhan
Yes, I was also not convinced, that is why I tested for multiple iterations. It seems to me the webrev.00 is the better "fix" as I saw only 2-3 pixels differ which cause the exact match to fail. But,I am not sure why in linux, the bufferedimages are exact. Maybe, there are some differences with

Re: [11] JDK-8190347: [TESTBUG] Test javax/swing/JWindow/ShapedAndTranslucentWindows/TranslucentJComboBox.java fails

2018-03-01 Thread Pankaj Bansal
Hi Sergey, JDK-8024627: This is not reproducible on Windows 10, but I can reproduce it on Ubuntu 16.04 and Mac. On Ubuntu, only the first click does not trigger the event, but subsequent clicks are triggered, but on Mac none of the clicks is triggered. The test javax/swing/JWindow/ShapedAndTran

Re: [11] RFR JDK-8198777: JList.getPreferredScrollableViewportSize(): fix mistake in doc for height calc

2018-03-01 Thread Alexey Ivanov
Hello Semyon, Thank you for your review. The updated version: http://cr.openjdk.java.net/~aivanov/8198777/webrev.1/ The case where the model is empty is covered in the paragraph above. No change is necessary there. Regards, Alexey On 01/03/2018 00:52, Semyon Sadetsky wrote: Hello Alexey,