Re: [11] Review Request: 8198342 Test FileSystemViewListenerLeak.java is unstable

2018-04-24 Thread Jayathirth D V
Hi Sergey, I went through the changes done in JDK-8175968 and I can understand why you would have added creation of multiple CustomFileSystemView like stress test scenario. But as you have mentioned in highly loaded systems there can sometimes be problem with CleanerFactory clearing all listene

Re: [11] Review Request: 8198342 Test FileSystemViewListenerLeak.java is unstable

2018-04-24 Thread Prasanta Sadhukhan
+1 Regards Prasanta On 4/25/2018 3:43 AM, Sergey Bylokhov wrote: Any volunteers to review? =) On 12/03/2018 22:27, Sergey Bylokhov wrote: Hello. Please review the update of the test for jdk11. Bug: https://bugs.openjdk.java.net/browse/JDK-8198342 Webrev can be found at: http://cr.openjdk.jav

Re: [11] Review Request: 8198342 Test FileSystemViewListenerLeak.java is unstable

2018-04-24 Thread Krishna Addepalli
Looks fine to me. -Original Message- From: Sergey Bylokhov Sent: Wednesday, April 25, 2018 3:43 AM To: swing-dev@openjdk.java.net Subject: Re: [11] Review Request: 8198342 Test FileSystemViewListenerLeak.java is unstable Any volunteers to review? =) On 12/03/2018 22:27, Sergey Bylokho

Re: [11][JDK-4842658] RFR: DefaultListModel and DefaultComboBoxModel should support addAll (Collection c)

2018-04-24 Thread Krishna Addepalli
Thanks for the review Sergey, but I have already updated the test appropriately. Also, please approve the CSR. Krishna -Original Message- From: Sergey Bylokhov Sent: Wednesday, April 25, 2018 3:42 AM To: Krishna Addepalli ; Andrej Golovnin Cc: swing-dev@openjdk.java.net Subject: Re: [

Re: [11] Review Request: 8198342 Test FileSystemViewListenerLeak.java is unstable

2018-04-24 Thread Sergey Bylokhov
Any volunteers to review? =) On 12/03/2018 22:27, Sergey Bylokhov wrote: Hello. Please review the update of the test for jdk11. Bug: https://bugs.openjdk.java.net/browse/JDK-8198342 Webrev can be found at: http://cr.openjdk.java.net/~serb/8198342/webrev.00 This test creates a number of FileSys

Re: [11][JDK-4842658] RFR: DefaultListModel and DefaultComboBoxModel should support addAll (Collection c)

2018-04-24 Thread Sergey Bylokhov
Looks fine. Please update the test as well before the push(it contains 'addAllElements, addAllElementsAt"). On 17/04/2018 21:00, Krishna Addepalli wrote: Hi Sergey, Here is the new webrev with the api names changed to “addAll” in DefaultComboBoxModel.java: http://cr.openjdk.java.net/~kaddep

Re: [11] RFR [JDK-8202064] Jemmy JInternalFrameOperator: Add wait for close(), activate(), resize() and move() operations

2018-04-24 Thread Sergey Bylokhov
+1 On 24/04/2018 05:40, Muneer Kolarkunnu wrote: Gentle Reminder! Regards, Muneer *From:* Muneer Kolarkunnu *Sent:* Friday, April 20, 2018 10:23 AM *To:* swing-dev@openjdk.java.net *Cc:* Aleksandre Iline *Subject:* [11] RFR [JDK-8202064] Jemmy JInternalFrameOperator: Add wait for close(),

Re: [11] RFR JDK-8189687:Swing: Invalid position of candidate pop-up of InputMethod in Hi-DPI on Windows

2018-04-24 Thread Sergey Bylokhov
BTW there is a typo: 3888 int sx = ScaleUpX(x) - p.x; 3889 int sy = ScaleUpX(y) - p.y; Thanks for the catch, fixed it. http://cr.openjdk.java.net/~ant/JDK-8202084/webrev.1 Looks fine. -- Best regards, Sergey.

Re: [11] RFR JDK-8189687:Swing: Invalid position of candidate pop-up of InputMethod in Hi-DPI on Windows

2018-04-24 Thread Sergey Bylokhov
On 24/04/2018 13:22, Anton Tarasov wrote: Clarification. The coordinate should not actually be split into displays every time it's scaled up/down. It's enough to calculate its offset in the "terminal" display and scale it accordingly. Then have all the displays already mapped b/w device and us

Re: [11] RFR JDK-8189687:Swing: Invalid position of candidate pop-up of InputMethod in Hi-DPI on Windows

2018-04-24 Thread Anton Tarasov
On 4/24/2018 9:07 PM, Anton Tarasov wrote: However, there's some serious problem in this construct which you may have noticed. It's here: x = peer->ScaleDownX(rect.left); 'rect.left' may span a number of displays, each with different scale. Thus, to get the real ScaleDown, rect.left should be

Re: [11] RFR JDK-8189687:Swing: Invalid position of candidate pop-up of InputMethod in Hi-DPI on Windows

2018-04-24 Thread Anton Tarasov
Hi Sergey, On 4/24/2018 4:48 AM, Sergey Bylokhov wrote: For the record, the fix which is under discussion: http://cr.openjdk.java.net/~ant/JDK-8202084/webrev.0 If I understand it correctly then GetHWnd() was replaced by ImmGetHWnd() to support the focus proxy. But note that ScaleUpX/ScaleUpY

Re: [11] RFR [JDK-8202064] Jemmy JInternalFrameOperator: Add wait for close(), activate(), resize() and move() operations

2018-04-24 Thread Muneer Kolarkunnu
Gentle Reminder! Regards, Muneer From: Muneer Kolarkunnu Sent: Friday, April 20, 2018 10:23 AM To: swing-dev@openjdk.java.net Cc: Aleksandre Iline Subject: [11] RFR [JDK-8202064] Jemmy JInternalFrameOperator: Add wait for close(), activate(), resize() and move() operations Hi All,