Re: [11] Review Request: 8198342 Test FileSystemViewListenerLeak.java is unstable

2018-04-25 Thread Jayathirth D V
Hi Sergey, Thanks for the clarification. Changes are fine. Regards, Jay -Original Message- From: Sergey Bylokhov Sent: Thursday, April 26, 2018 5:48 AM To: Jayathirth D V; swing-dev@openjdk.java.net Subject: Re: [11] Review Request: 8198342 Test FileSystemViewListenerLeak.java is unst

Re: [11] Review Request: 8198342 Test FileSystemViewListenerLeak.java is unstable

2018-04-25 Thread Sergey Bylokhov
Hi, Jay. On 24/04/2018 23:27, Jayathirth D V wrote: I went through the changes done in JDK-8175968 and I can understand why you would have added creation of multiple CustomFileSystemView like stress test scenario. But as you have mentioned in highly loaded systems there can sometimes be proble

Re: [11][JDK-4842658] RFR: DefaultListModel and DefaultComboBoxModel should support addAll (Collection c)

2018-04-25 Thread Krishna Addepalli
Hi Sergey, Phil Here is the link to CSR: https://bugs.openjdk.java.net/browse/JDK-8201289 I have updated the CSR as per the latest webrev. Thanks, Krishna -Original Message- From: Krishna Addepalli Sent: Wednesday, April 25, 2018 10:04 AM To: Sergey Bylokhov ; Andrej Golovnin Cc: swi

Re: [11] RFR JDK-8189687:Swing: Invalid position of candidate pop-up of InputMethod in Hi-DPI on Windows

2018-04-25 Thread Anton Tarasov
On 4/24/2018 11:55 PM, Sergey Bylokhov wrote: BTW there is a typo: 3888 int sx = ScaleUpX(x) - p.x; 3889 int sy = ScaleUpX(y) - p.y; Thanks for the catch, fixed it. http://cr.openjdk.java.net/~ant/JDK-8202084/webrev.1 Looks fine Thanks. As the fix now has two reviewers it can be pu

Re: [11] RFR JDK-8189687:Swing: Invalid position of candidate pop-up of InputMethod in Hi-DPI on Windows

2018-04-25 Thread Anton Tarasov
On 4/24/2018 11:53 PM, Sergey Bylokhov wrote: On 24/04/2018 13:22, Anton Tarasov wrote: Clarification. The coordinate should not actually be split into displays every time it's scaled up/down. It's enough to calculate its offset in the "terminal" display and scale it accordingly. Then have al