[12] RFR JDK-6828982: UIDefaults.getUI swallows original exception

2018-09-28 Thread Prasanta Sadhukhan
Hi All, Please review a fix for an issue where it is seen that UIDefaults.getUI() swallows the original exception and only emits InvocationTargetException without the original stacktrace/message. Proposed fix is to make sure the original exception/stackTrace is embedded in getUIError() message

Re: [12] RFR JDK-6994403:Grammatical error in documentation of javax.swing.GroupLayout.ParallelGroup

2018-09-28 Thread Sergey Bylokhov
Looks fine. On 28/09/2018 01:58, Prasanta Sadhukhan wrote: Hi All, Please review another doc fix where "its" is misspelt as "it's". Correct string should be as written in file copyright itself, "Copyright (c) 2006, 2015, Oracle and/or *its* affiliates" diff -r b5afdf0bbd9e src/java.desktop

Re: [12] JDK-6821316:comment in source code of SynthStyleFactory.java has a self-reference

2018-09-28 Thread Sergey Bylokhov
Looks fine. On 28/09/2018 03:07, Prasanta Sadhukhan wrote: Hi All, Please review another doc-fix where self reference is made in SynthSyleFactory diff -r d96a607e9594 src/java.desktop/share/classes/javax/swing/plaf/synth/SynthStyleFactory.java --- a/src/java.desktop/share/classes/javax/s

[12] JDK-6821316:comment in source code of SynthStyleFactory.java has a self-reference

2018-09-28 Thread Prasanta Sadhukhan
Hi All, Please review another doc-fix where self reference is made in SynthSyleFactory diff -r d96a607e9594 src/java.desktop/share/classes/javax/swing/plaf/synth/SynthStyleFactory.java --- a/src/java.desktop/share/classes/javax/swing/plaf/synth/SynthStyleFactory.java Tue Sep 18 18:32:03 201

Re: [12] JDK-8182043: Access to Windows Large Icons

2018-09-28 Thread Shashidhara Veerabhadraiah
Hi Alexey, Thank you for your thorough review. I have updated the copyrights as well and please see below for my comments:   Here is the new Webrev: http://cr.openjdk.java.net/~sveerabhadra/8182043/webrev.04/   Thanks and regards, Shashi   From: Alexey Ivanov Sent: Tuesday, September 25,

[12] RFR JDK-6994403:Grammatical error in documentation of javax.swing.GroupLayout.ParallelGroup

2018-09-28 Thread Prasanta Sadhukhan
Hi All, Please review another doc fix where "its" is misspelt as "it's". Correct string should be as written in file copyright itself, "Copyright (c) 2006, 2015, Oracle and/or *its* affiliates" diff -r b5afdf0bbd9e src/java.desktop/share/classes/javax/swing/GroupLayout.java --- a/src/java.de