Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

2018-10-22 Thread Philip Race
OK. If the progress bar is still not "user adjustable" then that should be fine. Wondering out loud ... is this the only Component class where such a thing matters. Most components won't change value on their own without some user intervention, so perhaps ProgressBar is (almost) unique ? But I e

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

2018-10-22 Thread Shashidhara Veerabhadraiah
Hi Phil, This change does not breaks the changing the value directly. I verified that. We need to use the tab key to traverse thro' components but the control never came to the progress bar hence it was not accessible. With this change control comes to it in the order and is now accessible. Th

Re: [12] RFR JDK-8192888: AllSwingComponentsBaselineTest fails with NullPointerException for NimbusLookAndFeel

2018-10-22 Thread Sergey Bylokhov
Hi, Prasanta. Thank you for investigation, the fix looks fine. On 21/10/2018 22:52, Prasanta Sadhukhan wrote: Hi Sergey, I saw that in *ButtonUI class for all lookandfeels, we are caching the ui object and returning AquaButtonUI - createUI() caches buttonUI via RecyclableSingletonFromDefaultC

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

2018-10-22 Thread Philip Race
On 10/22/18, 8:24 AM, Philip Race wrote: I'll partly answer my own question in so far as that if it doesn't have focus it probably isn't something that the AT would know is the component to be reading out ... but I expect it still should not be editable - please confirm this - and why is thi

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

2018-10-22 Thread Philip Race
I'll partly answer my own question in so far as that if it doesn't have focus it probably isn't something that the AT would know is the component to be reading out ... but I expect it still should not be editable - please confirm this - and why is this a Mac-specific issue ? -phil. On 10/22/18

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

2018-10-22 Thread Philip Race
SFAIK the intent of the demo is that the ProgressBar is not user adjustable so why does it have to be focusable ? It should not be possible to change its value directly, whether an AT is involved and you use the keyboard or directly with mouse. So does this change break that intent ? Why does

[12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

2018-10-22 Thread shashidhara . veerabhadraiah
Hi All, Please review a swingset fix for the below bug. Bug: https://bugs.openjdk.java.net/browse/JDK-7124285 Fix: http://cr.openjdk.java.net/~sveerabhadra/7124285/webrev.00/ Problem: The JProgressBar component used in the swingset demo was not focusable and once it is turned on, now the progr