Re: [12] Review Request: 8213817 @return has already been specified (4 occurrences, in AWT and Swing)

2018-11-15 Thread Phil Race
Since you saw these with a docs build I assume you also verified with a docs build. +1 on that assumption .. -phil. On 11/15/2018 10:42 AM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 12. Bug: https://bugs.openjdk.java.net/browse/JDK-8213817 Webrev: http://cr.openjdk.java.net

[12] Review Request: 8213817 @return has already been specified (4 occurrences, in AWT and Swing)

2018-11-15 Thread Sergey Bylokhov
Hello. Please review the fix for jdk 12. Bug: https://bugs.openjdk.java.net/browse/JDK-8213817 Webrev: http://cr.openjdk.java.net/~serb/8213817/webrev.00 In the fix a few duplicate @return tags were removed. Note that in a few places like: http://cr.openjdk.java.net/~serb/8213817/webrev.00/src/

Re: FYI: new javadoc tag to document system properties

2018-11-15 Thread Xuelei Fan
In JCE and JSSE, the public APIs definition (javax.net.ssl) and the internal implementation (sun.security.ssl) are separated. The system property can be defined in the internal implementation classes. I think we should add the @systemProperty on the public APIs, right? The public API class a