Re: [13] RFR JDK-8220250: fix headings in java.desktop

Any more comments on this http://cr.openjdk.java.net/~psadhukhan/8220250/webrev.2/ Regards Prasanta On 11-Mar-19 2:16 PM, Prasanta Sadhukhan wrote: The 2nd URL is based on webrev.1. I have placed new docs for webrev.2 here http://cr.openjdk.java.net/~psadhukhan/8220250/docs.webrev2/docs/api/ja

Re: [13] Review request for JDK-8216971: [macosx swing] For JCheckBoxMenuItem actionPerformed() is called twice, when apple.laf.useScreenMenuBar=true and modifier is InputEvent.

Hi Manajit, Thanks for the clarification. The fix looks ok to me. Thanks, Krishna > On 12-Mar-2019, at 3:36 PM, Manajit Halder wrote: > > Lines 74 to 82 explains why we need to ignore this call. This method should > be ignored if it is called as a result of user pressing a shortcut and the

Re: [12] JDK-8213516: jck test api/javax_accessibility/AccessibleState/fields.html fails intermittent

Hi Sergey, Please find the updated Webrev with fixes for the below comments: http://cr.openjdk.java.net/~sveerabhadra/8213516/webrev.06/ Thanks and regards, Shashi -Original Message- From: Sergey Bylokhov Sent: Wednesday, March 6, 2019 5:19 AM To: Shashidhara Veerabhadraiah ; Philip Ra

Re: [13] RFR JDK-8216353:Use utility APIs introduced in org/netbeans/jemmy/util/LookAndFeel class in client sanity test cases

Looks fine. On 11/03/2019 23:08, Vikrant Agarwal wrote: Hi All, Please review this fix forJDK-8216353 : Bug:https://bugs.openjdk.java.net/browse/JDK-8216353 Webrev: http://cr.openjdk.java.net/~vagarwal/8216353/webrev.1/ Summary: 1. The new

Re: [13] Review request for JDK-8216971: [macosx swing] For JCheckBoxMenuItem actionPerformed() is called twice, when apple.laf.useScreenMenuBar=true and modifier is InputEvent.

Lines 74 to 82 explains why we need to ignore this call. This method should be ignored if it is called as a result of user pressing a shortcut and the window containing the menu is not minimized. Regards, Manajit > On 12-Mar-2019, at 3:16 PM, Krishna Addepalli > wrote: > > Hi Manajit, > >

Re: [13] Review request for JDK-8216971: [macosx swing] For JCheckBoxMenuItem actionPerformed() is called twice, when apple.laf.useScreenMenuBar=true and modifier is InputEvent.

Hi Manajit, Thanks for the clarification. I think you should add some more comments around the statement at line86, to explain in more detail, about why to ignore this call. Thanks, Krishna > On 11-Mar-2019, at 2:25 PM, Manajit Halder wrote: > > Hi Krishna, > > Thanks for the review comment

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

Hi Joe, Thank you for that good suggestion. I have incorporated the same and here is the new Webrev:   http://cr.openjdk.java.net/~sveerabhadra/8216008/webrev.10/   Thanks and regards, Shashi   From: Joe Darcy Sent: Friday, March 8, 2019 2:42 PM To: Shashidhara Veerabhadraiah ; Philip Rac