Re: [13] RFR JDK-8212904:JTextArea line wrapping incorrect when using UI scale

2019-03-21 Thread Prasanta Sadhukhan
Hi Sergey, Thanks for your review. textarea.getLineCount() returns same number for both correct and broken wrap so it cannot be used for test automation... Regards Prasanta On 21-Mar-19 4:24 AM, Sergey Bylokhov wrote: Hi, Prasanta. The change looks fine, but probably the test can be

Re: [13] RFR JDK-8220250: fix headings in java.desktop

2019-03-21 Thread Prasanta Sadhukhan
I have not changed any build files. I only modified CompileJavaModules to see if it builds fine as was asked for. Regards Prasanta On 21-Mar-19 8:33 PM, Jonathan Gibbons wrote: Sounds good; note you should cc: build-dev@ojn for changes to build files. -- Jon On 3/21/19 3:23 AM, Prasanta

Re: [13] Review Request: 8177960 Deprecate the Swing Motif Look and Feel and document it as unsupported on macOS

2019-03-21 Thread Philip Race
Yes, please push this - the CSR is approved -phil On 3/4/19, 8:25 PM, Prasanta Sadhukhan wrote: Looks good to me. Regards Prasanta On 05-Mar-19 6:17 AM, Sergey Bylokhov wrote: Hello. Please review the fix for JDK 13. Bug: https://bugs.openjdk.java.net/browse/JDK-8177960 CSR:

Re: [13] RFR JDK-8220250: fix headings in java.desktop

2019-03-21 Thread Jonathan Gibbons
Sounds good; note you should cc: build-dev@ojn for changes to build files. -- Jon On 3/21/19 3:23 AM, Prasanta Sadhukhan wrote: FYI...it does build fine with this build change. Regards Prasanta On 19-Mar-19 10:58 PM, Jonathan Gibbons wrote: Prasanta, Note that if you believe you have fixed

Re: [13] RFR JDK-8220250: fix headings in java.desktop

2019-03-21 Thread Prasanta Sadhukhan
FYI...it does build fine with this build change. Regards Prasanta On 19-Mar-19 10:58 PM, Jonathan Gibbons wrote: Prasanta, Note that if you believe you have fixed all the heading issues in the java.desktop module, you can re-enable the doclint checks for the module by removing